Caution Warnings required

[kittycatto1]

Edit: Rewrote this and better tested for V1.0.0

You should already know some of these issues, but I'm putting them together here so it's easier to forward.
I doubt you could fix all of these but if possible and don't expect you to, but if possible. Could you please add some caution warnings to your Thunderstore and other important pages about the behaviour of this mod with the vanilla game and lobbies? Thanks in advance.

• The uncapper is setting "_maxQuantity" in save files to 999 (not really relevant, probably just the vanilla game?), which if the game refreshes those without the mod present causes them to be capped and erase the excess. These refreshes won't occur if you don't enter the character (because of how save data works) but will affect storage by wiping the excess
• Dropping an uncapped amount of items in a server without the mod will wipe the excess and only drop the vanilla amount, dropping it in a server with the mod works fine (visually and mechanically. You noted it first)
  • If the server has the mod and a client doesn't, they will see the uncapped numbers visually
    • Ran into a possible fluke where I dropped 654 Sapphite Ore and had a vanilla player pick it up but they crashed, couldn't grab the log unfortunately. They disconnected and then when they tried to reenter, their game soft-locked, a common thing for crashes I believe.

Credits: Xesy (guinea pig) and Catman & Marioalexsan

[Severnarch]

In your opinion, how is the warning section I've added now? Is there anything else that I should notably add to it?

As for testing your 4th point, I am trying to set up a way for me to host my own server and then join said server from another Atlyss intance, but it isn't going so well.

Excess wiping should hopefully be fixed from a recent commit I pushed.

[kittycatto1]

Hello. Apologies, my report was a bit shoddy and I was just working on rewriting it, I managed to get some more data and test my fourth point with a seemly fluke crash that we're looking into. Your note is a good start but unfortunately I didn't detail mine well enough to describe all prominent issues.

As for the crash, I was testing it with someone and dropped 654 Sapphite Ore after earlier dropping 2 Soul Pearls didn't cause any issues other than what my rewritten report will say, I tried to replicate it but couldn't get anything. I didn't save my log as the host unfortunately but took a screenshot.

[Severnarch]

Also, yeah, vanilla Atlyss is weird in how it saves max quantities in the save file, it just grabs the max quantity assigned to the item on exit then saves it as-is.

[Severnarch]

• Dropping an uncapped amount of items in a server without the mod will wipe the excess and only drop the vanilla amount, dropping it in a server with the mod works fine

This specific thing should be fixed for 1.0.1

[kittycatto1]

Great work, I'm currently busy but will do more testing soon.