Server freezes w/ Distant Horizons

[ceramic-ivy]

On a localhost game at least, the server seems to freeze occasionally when attempting to generate a new village. The client continues to run fine. Attempting to save and exit to the menu will cause it to never finish. This doesn't output anything and resource usage seems to remain normal. I could not get this to occur with only Road Architect or Distant Horizons enabled separately, though I was able to get this occur with both enabled multiple times.

Example: https://streamable.com/a24etq

Mods:

• Cloth Config v15 [15.0.140]
• Distant Horizons [2.3.6-b]
• Fabric API [0.116.7+1.21.1]
• RoadArchitect [1.6.2]

All mod configs were default, outside of CPU load for Distant Horizons, which was set to 'Minimal Load.'

[JenniferPylko]

i'm experiencing the same thing, i was able to mitigate it by turning distant horizon's thread count to 1 at 50% execution time, but it's still pretty hard on my cpu (ryzen 7 7840hs). no other optimizations have been effective (tried c2me, ferritecore, lithium, modernfix, redirected). with distant horizon's thread count at 4 with 100% execution time, all 16 cpu cores are pegged to 100% until there's a crash caused by a single tick taking over 60s.

i notice in the code

RoadArchitect/modules/common/src/main/java/net/oxcodsnet/roadarchitect/util/AsyncExecutor.java

Line 14 in ca37494

Math.max(2, Runtime.getRuntime().availableProcessors() - 1)

that it automatically takes all but 1 available logical processor, and the remaining 1 processor is not enough for everything else. it would be fantastic to have the number of threads here be a config option.