Fix HTML character escaping in JSON output#229
Merged
thepwagner merged 1 commit intoShopify:mainfrom Mar 6, 2026
Merged
Conversation
Preserve <, >, and & characters instead of escaping them to unicode equivalents (\u003c, \u003e, \u0026) during encrypt/decrypt cycle. Replace json.Marshal with custom quoteBytes implementation that only escapes characters required by JSON spec (quotes, backslashes, control characters) without HTML-safety escaping.
Contributor
Author
|
Alternatively we could try to ask upstream |
thepwagner
approved these changes
Mar 6, 2026
Contributor
thepwagner
left a comment
thepwagner
left a comment
There was a problem hiding this comment.
Thanks for the fix and the tests — this addresses #226 nicely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve
<,>, and&characters instead of escaping them to unicode equivalents (\u003c,\u003e,\u0026) during encrypt/decrypt cycle.Replace
json.Marshalwith customquoteBytesimplementation that only escapes characters required by JSON spec (quotes, backslashes, control characters) without HTML-safety escaping.Fixes #226