Fix doubled words in locale-check route comment#3681
Open
J8118 wants to merge 1 commit intoShopify:mainfrom
Open
Fix doubled words in locale-check route comment#3681J8118 wants to merge 1 commit intoShopify:mainfrom
J8118 wants to merge 1 commit intoShopify:mainfrom
Conversation
Fix "we still are still" → "we are still" and "the the locale" → "the locale" in comment block.
Contributor
Author
|
I have signed the CLA! |
fredericoo
approved these changes
Apr 13, 2026
Contributor
fredericoo
left a comment
fredericoo
left a comment
There was a problem hiding this comment.
LGTM - doubled words in a comment, clear fix.
andguy95
approved these changes
Apr 13, 2026
Contributor
|
cheers for the fix! this is currently failing CI because the branch is based on an older |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Fix doubled words in locale-check route comment
Description
Summary
Two doubled-word typos in the comment block of
locale-check.ts:"yet we still are still at the default locale"→"yet we are still at the default locale""then the the locale param must be invalid"→"then the locale param must be invalid"Files changed:
packages/cli/assets/routes/locale-check.ts— comment-only fixNote: This same text also appears in
packages/cli/CHANGELOG.md:792-793andtemplates/skeleton/CHANGELOG.md:2486-2487as part of historical changelog entries. Those are left as-is since changelogs are historical records.