Fix "overriden" typo to "overridden" in codegen test description#3682
Open
J8118 wants to merge 1 commit intoShopify:mainfrom
Open
Fix "overriden" typo to "overridden" in codegen test description#3682J8118 wants to merge 1 commit intoShopify:mainfrom
J8118 wants to merge 1 commit intoShopify:mainfrom
Conversation
Contributor
Author
|
I have signed the CLA! |
fredericoo
approved these changes
Apr 13, 2026
Contributor
fredericoo
left a comment
fredericoo
left a comment
There was a problem hiding this comment.
LGTM - typo in test description, no functional change.
andguy95
approved these changes
Apr 13, 2026
Contributor
|
cheers for the fix! this is currently failing CI because the branch is based on an older |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Fix "overriden" typo to "overridden" in codegen test
Description
Summary
A single
it()block name in the hydrogen-codegen type tests misspells "overridden" as "overriden":it('can be overriden', async () => {→it('can be overridden', async () => {Files changed:
packages/hydrogen-codegen/tests/client.test-d.ts— 1 test description fixTest plan