Customer Conversion Process - blank company, fax or region issue

[bluejohn1984]

Problem:

When extracting customers from Magento via the CLI, if an address has an empty company, fax or region field in Magento, the extracted json file is populated with "@xsi:type": "xsd:string" in those fields, and is retained in the csv file, during the conversion process. This value is then imported into shopify, which is not desirable.

However, when extracting orders, if a shipping or billing address has an empty company, fax or region field in Magento, it too is populated in the extracted json file as "@xsi:type": "xsd:string". However, during the csv conversion process, they are reported as errors eg. "company of the billing address is in an unexpected format. Transporter CLI expects it to be a string. Skipping company", and is not retained in the csv file, during the conversion process.

I believe the order conversion process is correct, and the customer conversion process has a flaw in not performing the same error checks, and excluding the incorrect values from the generated csv files.

Steps to Reproduce:

List the steps we can take to reproduce the problem:

1. Export a customer from Magento with a blank company, fax or region field in a customer address using the standard shopify_transporter extract --object=customer command.
2. Generate the customer csv file using the standard shopify_transporter convert --object=customer command.
3. Take the resulting csv and import into shopify using the app.