Issue description
In the config/settings_schema.json file of the Skeleton Theme, one of the schema objects has a trailing comma after the final element of its settings array. This causes JSON parsing tools (like jq) and theme validation to fail with errors such as:
jq: parse error: Expected another array element at line 23, column 5
Location:
config/settings_schema.json → the object with "name": "t:general.typography" → the settings array.
Impact:
• Developers cloning the repo or using it as a base theme will hit parse errors when running automation (e.g., scripts using jq) or validating theme files.
• It may block CI processes, theme checks, or updates before customization steps.
Suggested fix:
– Remove the trailing comma after the last settings item for the "t:general.typography" object.
– Validate the entire file as a well-formed JSON array (no trailing commas, no comments, top-level array structure as required by Shopify).
– Optionally add a simple test or CI check (e.g., jq . config/settings_schema.json) to prevent similar syntax issues in future commits.
Example corrected snippet:
{
"name": "t:general.typography",
"settings": [
{
"type": "header",
"content": "t:general.fonts"
},
{
"type": "font_picker",
"id": "type_primary_font",
"default": "work_sans_n4",
"label": "t:general.primary"
}
]
}
Thanks for maintaining this excellent starter theme — it’s a great foundation. If you’d like, I can submit a pull request with the fix and add a CI check to guard against future JSON formatting errors.
Issue description
In the config/settings_schema.json file of the Skeleton Theme, one of the schema objects has a trailing comma after the final element of its settings array. This causes JSON parsing tools (like jq) and theme validation to fail with errors such as:
jq: parse error: Expected another array element at line 23, column 5Location:
config/settings_schema.json → the object with "name": "t:general.typography" → the settings array.
Impact:
• Developers cloning the repo or using it as a base theme will hit parse errors when running automation (e.g., scripts using jq) or validating theme files.
• It may block CI processes, theme checks, or updates before customization steps.
Suggested fix:
– Remove the trailing comma after the last settings item for the "t:general.typography" object.
– Validate the entire file as a well-formed JSON array (no trailing commas, no comments, top-level array structure as required by Shopify).
– Optionally add a simple test or CI check (e.g., jq . config/settings_schema.json) to prevent similar syntax issues in future commits.
Example corrected snippet:
Thanks for maintaining this excellent starter theme — it’s a great foundation. If you’d like, I can submit a pull request with the fix and add a CI check to guard against future JSON formatting errors.