Conflict in parens rules around binary assignment

[gilbertbw]

Overview

I think there is a conflict in the @shopify/binary-assignment-parens and @typescript-eslint/no-extra-parens rules.

I have some code like:

const running = (this.state === 'running');

Which is getting the following error:

error Unnecessary parentheses around expression @typescript-eslint/no-extra-parens

from

web-configs/packages/eslint-plugin/lib/config/typescript.js

Line 205 in 5ab0fcf

'@typescript-eslint/no-extra-parens': 'error',

But if I change it to:

const running = this.state === 'running';

I get

error You must include parentheses around a binary assignment expression @shopify/binary-assignment-parens

from

web-configs/packages/eslint-plugin/lib/config/core.js

Line 270 in 5ab0fcf

'@shopify/binary-assignment-parens': ['error', 'always'],

Consuming repo

What repo were you working in when this issue occurred?

A private repository

Labels

• Add the Type: Bug label to this issue.

Area

• Add any relevant Area: <area> labels to this issue

Scope

• Is this issue related to a specific package?

  • Tag it with the Package: <package_name> label.

---

Checklist

• Please delete the labels section before submitting your issue
• I have described this issue in a way that is actionable (if possible)