-
Notifications
You must be signed in to change notification settings - Fork 57
Add lint rule to disallow contextmenu listeners (right-click) #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b3ecc9b to
1534a97
Compare
mxstbr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM! Thanks for adding such extensive tests.
|
You can comment |
|
/snapit |
|
🫰✨ Thanks @PhilippeCollin! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/eslint-plugin": "0.0.0-snapshot-20250311145226" |
1534a97 to
66fb520
Compare
|
/snapit |
|
🫰✨ Thanks @PhilippeCollin! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/eslint-plugin": "0.0.0-snapshot-20250311210802" |
|
/snapit |
|
🫰✨ Thanks @PhilippeCollin! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/eslint-plugin": "0.0.0-snapshot-20250311213039" |
|
Thanks for the suggestion @BPScott, I added the new rule to the |
|
Awesomeee. Let's shipit! |
Description
Add an eslint rule to disallow
contextmenuevent listeners. Overriding the default right click menu is generally unexpected and results in worse accessibility.At Shopify, we believe that this should almost never been done, except in some full-screen applications, like the Online Store Theme Editor, Figma, Google Docs, etc...