Skip to content

Commit 28a12ee

Browse files
committed
allow picking any language on Android 13+
1 parent b263a9d commit 28a12ee

File tree

2 files changed

+41
-10
lines changed

2 files changed

+41
-10
lines changed

app/src/main/kotlin/com/simplemobiletools/notes/pro/activities/SettingsActivity.kt

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,7 @@ import android.os.Bundle
55
import android.view.Menu
66
import com.simplemobiletools.commons.dialogs.RadioGroupDialog
77
import com.simplemobiletools.commons.extensions.*
8-
import com.simplemobiletools.commons.helpers.IS_CUSTOMIZING_COLORS
9-
import com.simplemobiletools.commons.helpers.NavigationIcon
10-
import com.simplemobiletools.commons.helpers.ensureBackgroundThread
11-
import com.simplemobiletools.commons.helpers.isOreoPlus
8+
import com.simplemobiletools.commons.helpers.*
129
import com.simplemobiletools.commons.models.RadioItem
1310
import com.simplemobiletools.notes.pro.R
1411
import com.simplemobiletools.notes.pro.extensions.config
@@ -18,6 +15,7 @@ import com.simplemobiletools.notes.pro.helpers.*
1815
import com.simplemobiletools.notes.pro.models.Widget
1916
import kotlinx.android.synthetic.main.activity_settings.*
2017
import java.util.*
18+
import kotlin.system.exitProcess
2119

2220
class SettingsActivity : SimpleActivity() {
2321
override fun onCreate(savedInstanceState: Bundle?) {
@@ -31,6 +29,7 @@ class SettingsActivity : SimpleActivity() {
3129

3230
setupCustomizeColors()
3331
setupUseEnglish()
32+
setupLanguage()
3433
setupAutosaveNotes()
3534
setupDisplaySuccess()
3635
setupClickableLinks()
@@ -79,17 +78,25 @@ class SettingsActivity : SimpleActivity() {
7978
}
8079

8180
private fun setupUseEnglish() {
82-
settings_use_english_holder.beVisibleIf(config.wasUseEnglishToggled || Locale.getDefault().language != "en")
81+
settings_use_english_holder.beVisibleIf((config.wasUseEnglishToggled || Locale.getDefault().language != "en") && !isTiramisuPlus())
8382
settings_use_english.isChecked = config.useEnglish
83+
settings_use_english_holder.setOnClickListener {
84+
settings_use_english.toggle()
85+
config.useEnglish = settings_use_english.isChecked
86+
exitProcess(0)
87+
}
88+
}
8489

85-
if (settings_use_english_holder.isGone()) {
90+
private fun setupLanguage() {
91+
settings_language.text = Locale.getDefault().displayLanguage
92+
settings_language_holder.beVisibleIf(isTiramisuPlus())
93+
94+
if (settings_use_english_holder.isGone() && settings_language_holder.isGone()) {
8695
settings_font_size_holder.background = resources.getDrawable(R.drawable.ripple_all_corners, theme)
8796
}
8897

89-
settings_use_english_holder.setOnClickListener {
90-
settings_use_english.toggle()
91-
config.useEnglish = settings_use_english.isChecked
92-
System.exit(0)
98+
settings_language_holder.setOnClickListener {
99+
launchChangeAppLanguageIntent()
93100
}
94101
}
95102

app/src/main/res/layout/activity_settings.xml

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,30 @@
114114

115115
</RelativeLayout>
116116

117+
<RelativeLayout
118+
android:id="@+id/settings_language_holder"
119+
style="@style/SettingsHolderTextViewStyle"
120+
android:layout_width="match_parent"
121+
android:layout_height="wrap_content"
122+
android:background="@drawable/ripple_top_corners">
123+
124+
<com.simplemobiletools.commons.views.MyTextView
125+
android:id="@+id/settings_language_label"
126+
style="@style/SettingsTextLabelStyle"
127+
android:layout_width="wrap_content"
128+
android:layout_height="wrap_content"
129+
android:text="@string/language" />
130+
131+
<com.simplemobiletools.commons.views.MyTextView
132+
android:id="@+id/settings_language"
133+
style="@style/SettingsTextValueStyle"
134+
android:layout_width="wrap_content"
135+
android:layout_height="wrap_content"
136+
android:layout_below="@+id/settings_language_label"
137+
tools:text="English" />
138+
139+
</RelativeLayout>
140+
117141
<RelativeLayout
118142
android:id="@+id/settings_font_size_holder"
119143
style="@style/SettingsHolderTextViewStyle"

0 commit comments

Comments
 (0)