From d745192ccd02c724e4d634e90175f2f654cb1e33 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mustafa=20=C3=96NCEL?= Date: Mon, 29 Dec 2025 18:25:01 +0300 Subject: [PATCH 1/4] Fix Recombobulated Runebook counting towards Recombobulated accessories progress --- src/stats/missing.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/stats/missing.go b/src/stats/missing.go index d0849aaf..11122840 100644 --- a/src/stats/missing.go +++ b/src/stats/missing.go @@ -66,7 +66,10 @@ func getEnrichments(accessories []models.InsertAccessory) map[string]int { func GetRecombobulatedCount(accessories []models.InsertAccessory) int { count := 0 for _, accessory := range accessories { - if accessory.Tag.ExtraAttributes.Recombobulated > 0 { + // NOTE: On the release of the new update, Hypixel forgot to stop users from recmbobulating the accessory and now some users have it recombobulated + // This is a temporary fix until they fix it (if they ever do). Example: https://cupcake.shiiyu.moe/stats/DeathStreeks/Blueberry + // Despite the accessory being Recombobulated, it's rarity does not change, so skip counting it towards recombobulated accessories but still show the item as recombobulated. + if accessory.Id != "RUNEBOOK" && accessory.Tag.ExtraAttributes.Recombobulated > 0 { count++ } } From e99db637f9788952948ad438f13355717f894e0d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mustafa=20=C3=96NCEL?= Date: Mon, 29 Dec 2025 20:28:56 +0300 Subject: [PATCH 2/4] Use existing AllowsRecomb field and explicit continue --- src/stats/missing.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/stats/missing.go b/src/stats/missing.go index 11122840..f70fde79 100644 --- a/src/stats/missing.go +++ b/src/stats/missing.go @@ -66,10 +66,11 @@ func getEnrichments(accessories []models.InsertAccessory) map[string]int { func GetRecombobulatedCount(accessories []models.InsertAccessory) int { count := 0 for _, accessory := range accessories { - // NOTE: On the release of the new update, Hypixel forgot to stop users from recmbobulating the accessory and now some users have it recombobulated - // This is a temporary fix until they fix it (if they ever do). Example: https://cupcake.shiiyu.moe/stats/DeathStreeks/Blueberry - // Despite the accessory being Recombobulated, it's rarity does not change, so skip counting it towards recombobulated accessories but still show the item as recombobulated. - if accessory.Id != "RUNEBOOK" && accessory.Tag.ExtraAttributes.Recombobulated > 0 { + if !accessory.AllowsRecomb { + continue + } + + if accessory.Tag.ExtraAttributes.Recombobulated > 0 { count++ } } From e66c62c68f7f7cf768948d5cf76321e07334c558 Mon Sep 17 00:00:00 2001 From: DuckySoLucky Date: Mon, 29 Dec 2025 18:35:24 +0100 Subject: [PATCH 3/4] fix: invalid check, use proper check --- src/stats/missing.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/stats/missing.go b/src/stats/missing.go index f70fde79..0486dd41 100644 --- a/src/stats/missing.go +++ b/src/stats/missing.go @@ -66,7 +66,7 @@ func getEnrichments(accessories []models.InsertAccessory) map[string]int { func GetRecombobulatedCount(accessories []models.InsertAccessory) int { count := 0 for _, accessory := range accessories { - if !accessory.AllowsRecomb { + if !constants.SPECIAL_ACCESSORIES[accessory.Id].AllowsRecomb { continue } From 920b15fdf1c55b2c87937b4f4e45adffd2bd581b Mon Sep 17 00:00:00 2001 From: DuckySoLucky Date: Mon, 29 Dec 2025 18:40:39 +0100 Subject: [PATCH 4/4] should test code --- NotEnoughUpdates-REPO | 2 +- src/stats/missing.go | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NotEnoughUpdates-REPO b/NotEnoughUpdates-REPO index 2e887058..96548d5e 160000 --- a/NotEnoughUpdates-REPO +++ b/NotEnoughUpdates-REPO @@ -1 +1 @@ -Subproject commit 2e887058aa349aadd892bd72bb5cb91c57cb353c +Subproject commit 96548d5e24f5e78ff269a5d8e12996ac26629f4d diff --git a/src/stats/missing.go b/src/stats/missing.go index 0486dd41..5accbb03 100644 --- a/src/stats/missing.go +++ b/src/stats/missing.go @@ -66,7 +66,8 @@ func getEnrichments(accessories []models.InsertAccessory) map[string]int { func GetRecombobulatedCount(accessories []models.InsertAccessory) int { count := 0 for _, accessory := range accessories { - if !constants.SPECIAL_ACCESSORIES[accessory.Id].AllowsRecomb { + specialAccessory, exists := constants.SPECIAL_ACCESSORIES[accessory.Id] + if exists && !specialAccessory.AllowsRecomb { continue }