Skip to content

Commit 0ada9bd

Browse files
Fix three broken test cases
1 parent c2b44e7 commit 0ada9bd

File tree

3 files changed

+6
-26
lines changed

3 files changed

+6
-26
lines changed

drivers/SmartThings/matter-sensor/src/test/test_matter_sensor.lua

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,10 @@ local function subscribe_on_init_presence_sensor(dev)
133133
end
134134

135135
local function test_init_presence_sensor()
136-
test.socket.matter:__expect_send({mock_device_presence_sensor.id, subscribe_on_init_presence_sensor(mock_device_presence_sensor)})
136+
test.disable_startup_messages()
137137
test.mock_device.add_test_device(mock_device_presence_sensor)
138+
test.socket.device_lifecycle:__queue_receive({ mock_device_presence_sensor.id, "init" })
139+
test.socket.matter:__expect_send({mock_device_presence_sensor.id, subscribe_on_init_presence_sensor(mock_device_presence_sensor)})
138140
test.socket.device_lifecycle:__queue_receive({ mock_device_presence_sensor.id, "doConfigure" })
139141
local read_attribute_list = clusters.PowerSource.attributes.AttributeList:read()
140142
test.socket.matter:__expect_send({mock_device_presence_sensor.id, read_attribute_list})

drivers/SmartThings/matter-switch/src/test/test_electrical_sensor.lua

Lines changed: 3 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,8 @@
1414

1515
local test = require "integration_test"
1616
local capabilities = require "st.capabilities"
17-
local t_utils = require "integration_test.utils"
18-
local uint32 = require "st.matter.data_types.Uint32"
1917
local clusters = require "st.matter.clusters"
18+
local t_utils = require "integration_test.utils"
2019
local version = require "version"
2120

2221
if version.api < 11 then
@@ -57,29 +56,9 @@ local mock_device = test.mock_device.build_test_matter_device({
5756
{cluster_id = clusters.LevelControl.ID, cluster_type = "SERVER", feature_map = 2}
5857
},
5958
device_types = {
60-
{ device_type_id = 0x010B, device_type_revision = 1 }, -- OnOff Dimmable Plug
61-
}
62-
},
63-
{
64-
endpoint_id = 3,
65-
clusters = {
66-
{ cluster_id = clusters.ElectricalEnergyMeasurement.ID, cluster_type = "SERVER", feature_map = 14, },
67-
{ cluster_id = clusters.PowerTopology.ID, cluster_type = "SERVER", feature_map = 4, }, -- SET_TOPOLOGY
68-
},
69-
device_types = {
70-
{ device_type_id = 0x0510, device_type_revision = 1 }, -- Electrical Sensor
59+
{ device_type_id = 0x010A, device_type_revision = 1 } -- OnOff Plug
7160
}
72-
},
73-
{
74-
endpoint_id = 4,
75-
clusters = {
76-
{ cluster_id = clusters.OnOff.ID, cluster_type = "SERVER", cluster_revision = 1, feature_map = 0, },
77-
{ cluster_id = clusters.LevelControl.ID, cluster_type = "SERVER", feature_map = 2},
78-
},
79-
device_types = {
80-
{ device_type_id = 0x010B, device_type_revision = 1 }, -- OnOff Dimmable Plug
81-
}
82-
},
61+
}
8362
},
8463
})
8564

drivers/SmartThings/matter-switch/src/test/test_matter_switch_device_types.lua

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -617,7 +617,6 @@ local function test_init_light_level_motion()
617617
test.socket.matter:__expect_send({mock_device_light_level_motion.id, subscribe_request})
618618

619619
test.socket.device_lifecycle:__queue_receive({ mock_device_light_level_motion.id, "doConfigure" })
620-
mock_device_light_level_motion:expect_metadata_update({ profile = "light-level-motion" })
621620
mock_device_light_level_motion:expect_metadata_update({ provisioning_state = "PROVISIONED" })
622621
end
623622

0 commit comments

Comments
 (0)