Merge pull request #268 from SmythOS/fix/core/secret-manager-connector

Fix/core/secret manager connector

Author: alaa-eddine-k

packages/core/src/helpers/S3Cache.helper.ts

@@ -4,6 +4,7 @@ import { GetBucketLifecycleConfigurationCommand } from '@aws-sdk/client-s3';
 import { S3Client } from '@aws-sdk/client-s3';
 import { Logger } from '@sre/helpers/Log.helper';
 const console = Logger('S3Cache');
+const lifeCycleRuleNotExistsErrorCode = 'NoSuchLifecycleConfiguration';
 
 export function generateLifecycleRules() {
     const rules = [];
@@ -121,7 +122,7 @@ export async function checkAndInstallLifecycleRules(bucketName: string, s3Client
             console.log('Lifecycle configuration already exists');
         }
     } catch (error) {
-        if (error.code === 'NoSuchLifecycleConfiguration') {
+        if (error.code === lifeCycleRuleNotExistsErrorCode || error.name === lifeCycleRuleNotExistsErrorCode) {
             console.log('No lifecycle configuration found. Creating new configuration...');
 
             const lifecycleRules = generateLifecycleRules();

packages/core/src/subsystems/Security/Vault.service/connectors/SecretsManager.class.ts

@@ -13,6 +13,7 @@ import {
     GetSecretValueCommandOutput,
 } from '@aws-sdk/client-secrets-manager';
 
+const defaultPrefix = 'smythos';
 const console = Logger('SecretsManager');
 
 export type SecretsManagerConfig = {
@@ -29,7 +30,7 @@ export class SecretsManager extends VaultConnector {
     constructor(protected _settings: SecretsManagerConfig) {
         super(_settings);
         //if (!SmythRuntime.Instance) throw new Error('SRE not initialized');
-        this.prefix = _settings.prefix || '';
+        this.prefix = _settings.prefix || defaultPrefix;
         this.secretsManager = new SecretsManagerClient({
             region: _settings.region,
             ...(_settings.awsAccessKeyId && _settings.awsSecretAccessKey