`bootstrap_resource_config.py` is defaulting to bash shell even when executing script inside zshrc

[svij-sc]

Ideally it should just ask for the shells, or give instructions on what to do.

[mfg5169]

looks like this is fixed?

[amosbarsinai]

I think this isn't relevant anymore.
Lines 94-100 are:

def infer_shell_file() -> str:
    """Infers the user's default shell configuration file."""
    shell = os.environ.get("SHELL", "")
    shell_config_map = {
        "zsh": "~/.zshrc",
        "bash": "~/.bashrc",
    }

Although I think SHELL might be unsafe. It can fail on some embedded systems/containers. It definitely doesn't work with non-UNIX systems - from what I recall, it's %COMSPEC% on Windows, but I'll assume a different script is called for Windows systems (couldn't find one though). The rest of the code in bootstrap_resource_config.py seems cross-platform.

I also noticed there's no support for shells that significantly differ from POSIX, like tsch or fish, even when the shell file is specified manually.

Edit: this definitely isn't safe if for some reason there are two different shell names in the absolute path defined in $SHELL. If my login shell is Zsh but for some reason it's installed in somepath/bash/zsh, it defaults to Bash syntax.