Build error when building djinni on macos 15.6 (xcode 26.0.1)

[sonicdebris]

Upgrading to xcode 26.0.1 on macos breaks the build (running src/run should be enough to reproduce).

It seems like there's some issue with the version of zlib, which is not a direct dependency, but looks like it's brought in by protobuf.

We tried to update protobuf version in bzl/deps.bzl but without luck.

We are still investigating and trying to solve the issue but we are not familiar with bazel, so any help would be appreciated.

This is the full output of the compilation (with the errors):

Starting local Bazel server and connecting to it...
INFO: Analyzed target //src:djinni (79 packages loaded, 1807 targets configured).
INFO: Found 1 target...
INFO: From Compiling uncompr.c:
external/zlib/uncompr.c:27:13: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
   27 | int ZEXPORT uncompress2 (dest, destLen, source, sourceLen)
      |             ^
external/zlib/uncompr.c:86:13: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
   86 | int ZEXPORT uncompress (dest, destLen, source, sourceLen)
      |             ^
2 warnings generated.
INFO: From Compiling gzread.c:
external/zlib/gzread.c:21:11: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
   21 | local int gz_load(state, buf, len, have)
      |           ^
external/zlib/gzread.c:56:11: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
   56 | local int gz_avail(state)
      |           ^
external/zlib/gzread.c:91:11: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
   91 | local int gz_look(state)
      |           ^
external/zlib/gzread.c:175:11: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
  175 | local int gz_decomp(state)
      |           ^
external/zlib/gzread.c:229:11: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
  229 | local int gz_fetch(state)
      |           ^
external/zlib/gzread.c:259:11: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
  259 | local int gz_skip(state, len)
      |           ^
external/zlib/gzread.c:294:16: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
  294 | local z_size_t gz_read(state, buf, len)
      |                ^
external/zlib/gzread.c:375:13: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
  375 | int ZEXPORT gzread(file, buf, len)
      |             ^
external/zlib/gzread.c:411:18: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
  411 | z_size_t ZEXPORT gzfread(buf, size, nitems, file)
      |                  ^
external/zlib/gzread.c:447:13: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
  447 | int ZEXPORT gzgetc(file)
      |             ^
external/zlib/gzread.c:474:13: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
  474 | int ZEXPORT gzgetc_(file)
      |             ^
external/zlib/gzread.c:481:13: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
  481 | int ZEXPORT gzungetc(c, file)
      |             ^
external/zlib/gzread.c:541:16: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
  541 | char * ZEXPORT gzgets(file, buf, len)
      |                ^
external/zlib/gzread.c:605:13: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
  605 | int ZEXPORT gzdirect(file)
      |             ^
external/zlib/gzread.c:625:13: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
  625 | int ZEXPORT gzclose_r(file)
      |             ^
15 warnings generated.
INFO: From Compiling gzclose.c:
external/zlib/gzclose.c:11:13: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
   11 | int ZEXPORT gzclose(file)
      |             ^
1 warning generated.
ERROR: /private/var/tmp/_bazel_athos/eb41b50b852dc5229980cead04bc36c3/external/zlib/BUILD.bazel:37:11: Compiling zutil.c failed: (Aborted): wrapped_clang failed: error executing command external/local_config_cc/wrapped_clang '-D_FORTIFY_SOURCE=1' -fstack-protector -fcolor-diagnostics -Wall -Wthread-safety -Wself-assign -fno-omit-frame-pointer -g0 -O2 -DNDEBUG '-DNS_BLOCK_ASSERTIONS=1' ... (remaining 33 arguments skipped)

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
In file included from external/zlib/zutil.c:8:
external/zlib/zutil.h:170:11: warning: 'OS_CODE' macro redefined [-Wmacro-redefined]
  170 | #  define OS_CODE 19
      |           ^
external/zlib/zutil.h:141:11: note: previous definition is here
  141 | #  define OS_CODE  7
      |           ^
In file included from external/zlib/zutil.c:10:
In file included from external/zlib/gzguts.h:21:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX26.0.sdk/usr/include/stdio.h:61:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX26.0.sdk/usr/include/_stdio.h:322:7: error: expected identifier or '('
  322 | FILE    *fdopen(int, const char *) __DARWIN_ALIAS_STARTING(__MAC_10_6, __IPHONE_2_0, __DARWIN_ALIAS(fdopen));
      |          ^
external/zlib/zutil.h:147:33: note: expanded from macro 'fdopen'
  147 | #        define fdopen(fd,mode) NULL /* No fdopen() */
      |                                 ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/17/include/__stddef_null.h:26:16: note: expanded from macro 'NULL'
   26 | #define NULL ((void*)0)
      |                ^
In file included from external/zlib/zutil.c:10:
In file included from external/zlib/gzguts.h:21:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX26.0.sdk/usr/include/stdio.h:61:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX26.0.sdk/usr/include/_stdio.h:322:7: error: expected ')'
external/zlib/zutil.h:147:33: note: expanded from macro 'fdopen'
  147 | #        define fdopen(fd,mode) NULL /* No fdopen() */
      |                                 ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/17/include/__stddef_null.h:26:16: note: expanded from macro 'NULL'
   26 | #define NULL ((void*)0)
      |                ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX26.0.sdk/usr/include/_stdio.h:322:7: note: to match this '('
external/zlib/zutil.h:147:33: note: expanded from macro 'fdopen'
  147 | #        define fdopen(fd,mode) NULL /* No fdopen() */
      |                                 ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/17/include/__stddef_null.h:26:15: note: expanded from macro 'NULL'
   26 | #define NULL ((void*)0)
      |               ^
In file included from external/zlib/zutil.c:10:
In file included from external/zlib/gzguts.h:21:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX26.0.sdk/usr/include/stdio.h:61:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX26.0.sdk/usr/include/_stdio.h:322:7: error: expected ')'
  322 | FILE    *fdopen(int, const char *) __DARWIN_ALIAS_STARTING(__MAC_10_6, __IPHONE_2_0, __DARWIN_ALIAS(fdopen));
      |          ^
external/zlib/zutil.h:147:33: note: expanded from macro 'fdopen'
  147 | #        define fdopen(fd,mode) NULL /* No fdopen() */
      |                                 ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/17/include/__stddef_null.h:26:22: note: expanded from macro 'NULL'
   26 | #define NULL ((void*)0)
      |                      ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX26.0.sdk/usr/include/_stdio.h:322:7: note: to match this '('
external/zlib/zutil.h:147:33: note: expanded from macro 'fdopen'
  147 | #        define fdopen(fd,mode) NULL /* No fdopen() */
      |                                 ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/17/include/__stddef_null.h:26:14: note: expanded from macro 'NULL'
   26 | #define NULL ((void*)0)
      |              ^
external/zlib/zutil.c:133:22: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
  133 | const char * ZEXPORT zError(err)
      |                      ^
external/zlib/zutil.c:305:22: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
  305 | voidpf ZLIB_INTERNAL zcalloc (opaque, items, size)
      |                      ^
external/zlib/zutil.c:315:20: warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C23 [-Wdeprecated-non-prototype]
  315 | void ZLIB_INTERNAL zcfree (opaque, ptr)
      |                    ^
4 warnings and 3 errors generated.
Error in child process '/usr/bin/xcrun'. 1
Target //src:djinni failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 17.201s, Critical Path: 2.70s
INFO: 182 processes: 39 internal, 143 darwin-sandbox.

[li-feng-sc]

Hi @sonicdebris

I have fixed this in the experimental branch in this PR
#197

[li-feng-sc]

I am aware that the main branch has lagged behind and are missing many changes from the experimental branch, but I currently don't have the bandwidth to do more work on Djinni.

[sonicdebris]

Thanks a lot @li-feng-sc, we'll cherry pick this fix. Not sure about the rest of the content of the experimental branch, but just to help other people facing the same issue but that are not aware of this conversation, it might be easy enough to just adopt the fix on main. I can open a PR if it sounds like a good idea but you have no time to deal with it.