From 134a9f2e540b910d5f01a452764e2342a40e485a Mon Sep 17 00:00:00 2001 From: Dimitris Mantzouranis Date: Sun, 30 Mar 2025 13:30:08 +0300 Subject: [PATCH 1/6] expose wails -debug option --- action.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/action.yml b/action.yml index 1060d9a..dd1016f 100644 --- a/action.yml +++ b/action.yml @@ -27,6 +27,10 @@ inputs: description: "Cache the build" required: false default: "true" + build-debug: + description: "Retain debug info and show debug console" + required: false + default: "false" build-platform: description: "Platform to build for" required: false @@ -139,6 +143,9 @@ runs: DISTRO: ${{ steps.linux_discovery.outputs.DISTRO }} run: | build_options="" + if ${{ inputs.build-debug == 'true' }}; then + build_options+=' -debug' + fi if ${{ inputs.build-obfuscate == 'true' }}; then build_options+=' -obfuscated' fi From c2143090f293f4688968314a5418e07f5ea1403a Mon Sep 17 00:00:00 2001 From: Dimitris Mantzouranis Date: Sun, 30 Mar 2025 13:36:41 +0300 Subject: [PATCH 2/6] expose wails -windowsconsole option --- action.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/action.yml b/action.yml index dd1016f..7afe6a5 100644 --- a/action.yml +++ b/action.yml @@ -43,6 +43,10 @@ inputs: description: "Obfuscate the build" required: false default: "false" + build-windowsconsole: + description: "Keep the console window for Windows builds" + required: false + default: "false" wails-version: description: "Wails version to use" required: false @@ -149,6 +153,9 @@ runs: if ${{ inputs.build-obfuscate == 'true' }}; then build_options+=' -obfuscated' fi + if ${{ inputs.build-windowsconsole == 'true' }}; then + build_options+=' -windowsconsole' + fi if [[ "${{ inputs.build-tags }}" != "false" ]]; then tags_string="${{ inputs.build-tags }}" if [[ "$DISTRO" == '24.04' ]]; then From f61fcfc446ef4a800ee5d37f654129ce895e8bed Mon Sep 17 00:00:00 2001 From: Dimitris Mantzouranis Date: Sun, 30 Mar 2025 13:42:25 +0300 Subject: [PATCH 3/6] expose wails -ldflags option --- action.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/action.yml b/action.yml index 7afe6a5..2a61a63 100644 --- a/action.yml +++ b/action.yml @@ -31,6 +31,10 @@ inputs: description: "Retain debug info and show debug console" required: false default: "false" + build-ldflags: + description: "Additional ldflags to pass to Go compiler. Must be quoted" + required: false + default: "false" build-platform: description: "Platform to build for" required: false @@ -150,6 +154,10 @@ runs: if ${{ inputs.build-debug == 'true' }}; then build_options+=' -debug' fi + if [[ "${{ inputs.build-ldflags }}" != "false" ]]; then + ldflags_string="${{ inputs.build-ldflags }}" + build_options+=" -ldflags $ldflags_string" + fi if ${{ inputs.build-obfuscate == 'true' }}; then build_options+=' -obfuscated' fi From 9d603cedbd5de7f849ad8878498f060f9379497b Mon Sep 17 00:00:00 2001 From: Evan Sosenko Date: Tue, 8 Apr 2025 16:04:20 -0700 Subject: [PATCH 4/6] Add = for ldflags --- action.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/action.yml b/action.yml index 2a61a63..96b4c07 100644 --- a/action.yml +++ b/action.yml @@ -156,7 +156,7 @@ runs: fi if [[ "${{ inputs.build-ldflags }}" != "false" ]]; then ldflags_string="${{ inputs.build-ldflags }}" - build_options+=" -ldflags $ldflags_string" + build_options+=" -ldflags=$ldflags_string" fi if ${{ inputs.build-obfuscate == 'true' }}; then build_options+=' -obfuscated' @@ -169,8 +169,8 @@ runs: if [[ "$DISTRO" == '24.04' ]]; then tags_string+=" webkit2_41" fi - build_options+=" -tags $tags_string" - elif [[ "${{ inputs.build-tags }}" == "false" && "$DISTRO" == '24.04' ]]; then + build_options+=" -tags $tags_string" + elif [[ "${{ inputs.build-tags }}" == "false" && "$DISTRO" == '24.04' ]]; then build_options+=" -tags webkit2_41" fi if ${{ inputs.nsis == 'true' }}; then From cd53552504988be7bb18af1a178d51edc8405fdc Mon Sep 17 00:00:00 2001 From: Evan Sosenko Date: Tue, 8 Apr 2025 16:15:02 -0700 Subject: [PATCH 5/6] Single quote ldflags --- action.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/action.yml b/action.yml index 96b4c07..0816c6c 100644 --- a/action.yml +++ b/action.yml @@ -32,7 +32,7 @@ inputs: required: false default: "false" build-ldflags: - description: "Additional ldflags to pass to Go compiler. Must be quoted" + description: "Additional ldflags to pass to Go compiler." required: false default: "false" build-platform: @@ -156,7 +156,7 @@ runs: fi if [[ "${{ inputs.build-ldflags }}" != "false" ]]; then ldflags_string="${{ inputs.build-ldflags }}" - build_options+=" -ldflags=$ldflags_string" + build_options+=" -ldflags='$ldflags_string'" fi if ${{ inputs.build-obfuscate == 'true' }}; then build_options+=' -obfuscated' From f8b90a113b5f744d191c845a09040632e8821a11 Mon Sep 17 00:00:00 2001 From: Evan Sosenko Date: Tue, 8 Apr 2025 16:17:48 -0700 Subject: [PATCH 6/6] Pass options directly --- action.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/action.yml b/action.yml index 0816c6c..f0d7e44 100644 --- a/action.yml +++ b/action.yml @@ -176,7 +176,7 @@ runs: if ${{ inputs.nsis == 'true' }}; then build_options+=' -nsis' fi - echo "BUILD_OPTIONS=$build_options" >> "$GITHUB_OUTPUT" + echo "build_options=$build_options" >> "$GITHUB_OUTPUT" # Setup and configure GoLang - name: Setup GoLang uses: actions/setup-go@v5 @@ -215,10 +215,8 @@ runs: # Building step - name: Build App if: inputs.build == 'true' - env: - BUILD_OPTIONS: ${{ steps.build_options.outputs.BUILD_OPTIONS }} working-directory: ${{ inputs.app-working-directory }} - run: wails build --platform ${{inputs.build-platform}} -webview2 ${{inputs.wails-build-webview2}} -o ${{inputs.build-name}} $BUILD_OPTIONS + run: wails build --platform ${{inputs.build-platform}} -webview2 ${{inputs.wails-build-webview2}} -o ${{inputs.build-name}} ${{ steps.build_options.outputs.build_options }} shell: bash - name: Add macOS perms if: inputs.build == 'true' && runner.os == 'macOS'