Skip to content

[DO NOT MERGE] Snowbridge V2 Tip Support #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
claravanstaden wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

[DO NOT MERGE] Snowbridge V2 Tip Support #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a56b312
switch impl based on snowbridge v2 flag
claravanstaden Nov 20, 2025
95a336a
snowbridge v2 to AH support
claravanstaden Nov 24, 2025
0576e41
v2 support
claravanstaden Nov 25, 2025
bf2aaa3
refactor
claravanstaden Nov 26, 2025
c37110f
add log
claravanstaden Nov 26, 2025
5a74730
bump version
claravanstaden Nov 26, 2025
8ec627f
Merge remote-tracking branch 'origin/main' into clara/snowbridge-v2-s…
claravanstaden Nov 26, 2025
f0784ca
Merge branch 'refs/heads/main' into clara/snowbridge-v2-support
claravanstaden Nov 27, 2025
40d67a6
lock file
claravanstaden Nov 27, 2025
6b7db3f
Merge branch 'main' into clara/snowbridge-v2-support
claravanstaden Dec 1, 2025
0b24a37
add tip dialog
claravanstaden Dec 2, 2025
cfd23fd
tweaks
claravanstaden Dec 2, 2025
c4d291c
Merge branch 'main' into clara/snowbridge-v2-support
claravanstaden Dec 2, 2025
30b9ea3
merge damage
claravanstaden Dec 2, 2025
a0e39d3
fixes
claravanstaden Dec 2, 2025
0daed2b
revert max and form changes
claravanstaden Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 47 additions & 4 deletions app/history/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,44 @@ import { AppRouterInstance } from "next/dist/shared/lib/app-router-context.share

const ITEMS_PER_PAGE = 5;

/**
* Check if two transfers are the same by comparing their unique identifiers.
* For V2 transfers, the backend returns database-generated IDs, while locally
* created transfers use messageId/txHash as ID. This function matches by
* transaction hash or extrinsic hash to handle this case.
*/
const isSameTransfer = (t1: Transfer, t2: Transfer): boolean => {
// Match by ID if both have non-empty IDs
if (t1.id === t2.id && t1.id.length > 0) return true;

// For ToPolkadotTransferResult (E->P), match by transaction hash
if (t1.sourceType === "ethereum" && t2.sourceType === "ethereum") {
const t1Casted = t1 as historyV2.ToPolkadotTransferResult;
const t2Casted = t2 as historyV2.ToPolkadotTransferResult;
if (
t1Casted.submitted.transactionHash ===
t2Casted.submitted.transactionHash &&
t1Casted.submitted.transactionHash.length > 0
) {
return true;
}
}

// For ToEthereumTransferResult (P->E), match by extrinsic hash
if (t1.sourceType === "substrate" && t2.sourceType === "substrate") {
const t1Casted = t1 as historyV2.ToEthereumTransferResult;
const t2Casted = t2 as historyV2.ToEthereumTransferResult;
if (
t1Casted.submitted.extrinsic_hash === t2Casted.submitted.extrinsic_hash &&
t1Casted.submitted.extrinsic_hash.length > 0
) {
return true;
}
}

return false;
};

const getExplorerLinks = (
transfer: Transfer,
source: assetsV2.TransferLocation,
Expand Down Expand Up @@ -451,9 +489,8 @@ export default function History() {
const oldTransferCutoff = new Date().getTime() - 4 * 60 * 60 * 1000; // 4 hours
for (let i = 0; i < transfersPendingLocal.length; ++i) {
if (
transferHistoryCache.find(
(h) =>
h.id?.toLowerCase() === transfersPendingLocal[i].id?.toLowerCase(),
transferHistoryCache.find((h) =>
isSameTransfer(h, transfersPendingLocal[i]),
) ||
new Date(transfersPendingLocal[i].info.when).getTime() <
oldTransferCutoff
Expand All @@ -479,7 +516,13 @@ export default function History() {
]);
const allTransfers: Transfer[] = [];
for (const pending of transfersPendingLocal) {
if (transferHistoryCache.find((t) => t.id === pending.id)) {
// Check if this pending transfer already exists in the cache
// Match by ID, transaction hash, or message ID to handle V2 transfers
const isDuplicate = transferHistoryCache.find((t) =>
isSameTransfer(t, pending),
);

if (isDuplicate) {
continue;
}
allTransfers.push(pending);
Expand Down
53 changes: 52 additions & 1 deletion app/txcomplete/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { Transfer } from "@/store/transferHistory";
import base64url from "base64url";
import { LucideLoaderCircle } from "lucide-react";
import { useSearchParams } from "next/navigation";
import { Suspense, useContext, useMemo } from "react";
import { Suspense, useContext, useMemo, useState } from "react";
import { TransferStatusBadge } from "@/components/history/TransferStatusBadge";
import { Button } from "@/components/ui/button";
import Link from "next/link";
Expand All @@ -38,6 +38,7 @@ import { useAtom, useAtomValue } from "jotai";
import { walletTxChecker } from "@/utils/addresses";
import { NeuroWebUnwrapForm } from "@/components/transfer/NeuroWebUnwrapStep";
import { ethereumAccountAtom, ethereumAccountsAtom } from "@/store/ethereum";
import { AddTipDialog } from "@/components/AddTipDialog";

const Loading = () => {
return (
Expand All @@ -58,6 +59,11 @@ function TxCard(props: TxCardProps) {
const { transfer, refresh, inHistory, registry } = props;
const { destination } = getEnvDetail(transfer, registry);
const links: { name: string; link: string }[] = [];
const [tipDialogOpen, setTipDialogOpen] = useState(false);
const [tipParams, setTipParams] = useState<{
direction: "Inbound" | "Outbound";
nonce: number;
} | null>(null);

const token =
registry.ethereumChains[registry.ethChainId].assets[
Expand Down Expand Up @@ -199,6 +205,51 @@ function TxCard(props: TxCardProps) {
</ul>
</div>
{neuroWeb}
<div
className={cn(
transfer.status !== historyV2.TransferStatus.Complete
? ""
: "hidden",
)}
>
<Button
variant="outline"
onClick={() => {
// Get nonce and direction based on transfer type
let nonce: number | undefined;
let direction: "Inbound" | "Outbound" | undefined;

if (transfer.sourceType === "ethereum") {
const t = transfer as historyV2.ToPolkadotTransferResult;
nonce = t.submitted.nonce;
direction = "Inbound";
} else if (transfer.sourceType === "substrate") {
const t = transfer as historyV2.ToEthereumTransferResult;
nonce = t.bridgeHubMessageAccepted?.nonce;
direction = "Outbound";
}

if (nonce !== undefined && direction) {
setTipParams({ direction, nonce });
setTipDialogOpen(true);
} else {
alert(
"Tip cannot be added yet. The transfer must reach the bridge hub first.",
);
}
}}
>
Add Tip
</Button>
{tipParams && (
<AddTipDialog
open={tipDialogOpen}
onOpenChange={setTipDialogOpen}
direction={tipParams.direction}
nonce={tipParams.nonce}
/>
)}
</div>
<div className="flex justify-between items-center">
<Link
className={cn("underline text-sm", !inHistory ? "hidden" : "")}
Expand Down
Loading