[Help wanted] Unity Support

[nnra6864]

This extension currently lacks proper unity support.
Known issues are:
#207
#217

[SofusA]

I don't have any experience with unity.

Can you provide a git repository for a unity project where i can test if it works or not?

[nnra6864]

Hey, thanks for taking a look at this.
Unity has a few sample projects: https://unity.com/demos
I am not entirely sure which one would be good for testing, probably just go for the most minimal one.

[kinggoldcatter]

Unity also comes with a handful of simpler smaller templates to use, im am willing to make a quick repo that has a moving square or something if that is preferable.

[kinggoldcatter]

https://github.com/kinggoldcatter/C-Sharp-LSP-Unity-Test
Here we go I made a basic scene with a ball you can roll around, assuming I did it correct you should also be able to test the lsp without installing unity but someone will need to check that. I added some notes in the read me but just know the only important file to look at is Assets/MovingSphere.cs the rest is just for Unity's sake.
Feel Free to ask for help or whatever

[SofusA]

I am able to get this working.

I deleted sln and csproj from the repo, opened the project in unity and ran dotnet restore.

[kinggoldcatter]

Interesting I was also able to get it working once without being able to recreate it. Once I have a moment ill see if I can find out what I did that made it break agine

[kinggoldcatter]

Ok so after playing around for a bit It seems for this simple scene even pressing regen project files, even closing and opening the project works!

1. there is unity specific analysis (amazing)
2. you do need just spam inputs or something for it to update after it takes a second to initialize (annoying but fine)
3. The lsp does need a restart after adding any new scripts (also annoying)

However further testing I did finds it breaks on my larger projects my theory is that it is due to more then one .csproj being added breaks the lsp somehow.
(which is unfortunately common when dealing with plugins.)

The reason it works on the basic scene is it appears unity has a Assembly-CSharp.csproj and a Assembly-CSharp-Editor.csproj (which is why it dosent work by default), but for whatever reason on this simple scene unity only recreates the Assembly-CSharp.csproj if you delete all the .csprojs

running dotnet restore on all the new project files does not work either.
it still outputs all these annoying Roslyn restore errors maybe it wants it in a specific order?

It is cool base unity works like this but give me a moment to try making a second project that can recreate adding more then one .csproj to look at.

never-mind read my new comment the LSP is fine with multiple assembly references or csproj files

[kinggoldcatter]

I was wrong about the cs proj thing you can have as many as you want

So im not sure what exactly fixed it because it randomly worked after going to the bathroom and reopening unity (there was probably some delay or something)

but before it worked itself out I

1. dotnet restored all csproj files using a bash script (I did this a bunch before the last comment so I doubt it was this by itself)
2. updated the visual studio for unity plugin from 2.0.23 to version 2.0.25
3. used the dotnet restore script one more time
4. Used open C# Project with visual studio to look at their LSP log for any help

It then worked when I reopened helix so one of these or a combination fixed whatever was wrong.

[kinggoldcatter]

if nnra can also get their project working with zed id call this issue complete, but there should probably be a note somewhere on getting unity to work

[SofusA]

I think the issue probably boils down to projects needs to be restored. The language server sends a “project needs to be restored” notification, which vscode reacts to.

I might be able to do this in this wrapper. I will investigate
That is probably not possible

Btw. You can restore a .sln and then all linked projects will be restored

[nnra6864]

Ok, so I tried again and it's still not working.

I first tried just opening the project that works fine with regular omnisharp and dotrush, same issue.

Then I tried running dotnet restore ProjectName.sln, which succeeded, but still the same issue.

After that, I tried using the Regenerate Project Files(which helps with autocompletions sometimes), still nothing.

And lastly, since @kinggoldcatter mentioned using visual studio to open the project, I opened it with rider to see if regenerating project files with that would help, still nothing.
I just keep getting recommendations only from that same class, can't use other classes or namespaces.

No UnityEngine.Audio recommendations(even tho I am using it above):

No other class recommendations:

Same class recommendations:

I would give visual studio a try too, but I can't since I am on linux.
Any other recommendations?

[SofusA]

Is this also the case for the repository that @kinggoldcatter shared?

Also does the generated project from dotnet new console --use-program-main --name test work as expected?

[nnra6864]

@kinggoldcatter's project doesn't work either.
I cloned, tried the extension, tried dotnet restore, all the same.

[nnra6864]

As for the regular console app, p sure I mentioned that works fine in the first issue I made, but yeah, that works as expected.