SolidOS Auth Upgrade

[jaxoncreed]

This ticket Represents Sub-Project 1 of the SolidOS Auth upgrade:

See #38 (comment) for the official announcement of the completion of this project.

• solid-client-authn-js-browser is integrated in SolidOS
• Login header has a new UI for selecting the issuer
• All tests are updated to work with the new login
• Solid Test Suite passes (Does the test suite even touch this code? I don't think so)
• Login to ESS on SolidOS Hosted from NSS
• Login to NSS on SolidOS Hosted from NSS
• Login to CSS on SolidOS Hosted from NSS
• Login to ESS on SolidOS Hosted from Data Kitchen (ESS broker crashes when you have a file:// redirect)
• Login to NSS on SolidOS Hosted from Data Kitchen
• Login to CSS on SolidOS Hosted from Data Kitchen (CSS IdP rejects file:// redirects)
• Login to ESS on SolidOS Hosted as a separate webpage
• Login to NSS on SolidOS Hosted as a separate webpage
• Login to CSS on SolidOS Hosted as a separate webpage
• Refreshing the page does not log the user out
• Problem to note: NSS handles a failed requests with a separate webpage. It should instead send a data browser.
• Problem to note: Anything in an iframe (Dokeli) cannot get access to the credentials and will not be allowed
• Problem to note: any hash (like #me) is removed upon redirect. This could be accounted for either in Solid-Client-Authn-JS or inside the data browser
• Problem to note: Alain gets ReferenceError: TextEncoder is not defined with node v16.5, v14.17 or v12.19 on a windows WSL1 to build.
• Problem to note: logout do not really log you out until you refresh the page.
• Problem to note: switching users doesn't work
• Problem to note: Redirects will always go to the same page you've redirected from. This problem is known here: handleIncomingRedirect restore all query parameters but shouldn't inrupt/solid-client-authn-js#1473. Solution: Save the current url and navigate to that upon refresh.
• Node-Solid-Server fails against the test suite due to 412 statuses
• Problem to note: In some cases (Ask Timea for the cases) the logout button fails to load. She believes the problem is here: https://github.com/solid/solid-ui/blob/auth-upgrade/src/authn/authn.ts#L1152
• Log in to one place and log into another see if there are problems
• List inrupt.net and inrupt.com on login ui
• Home page is not displaying
• Test other panes like dokeli
  • activitystreams-pane
  • chat-pane
  • contacts-pane (There are also build problems on this one)
  • folder-pane
  • issue-pane
  • money-pane
  • source-pane
  • dokie.li (no way to deal with this outside of not using an iFrame)
• Figure out what the types should be on the rdflib
• Upgrade all references to authSession to things like currentUser
• Logout from NSS problem with cookies
• Solidweb too many redirects (Unable to replicate. This probably can be solved by clearing cookies on solidweb.org)
• Upgrade NSS tests to work with that cookie
• Deploy

The following libraries are linter and test fixes that should be merged in first:

• Mashlib (Updated linter so test script works mashlib#121)
• Solid-Panes (Fixed linters and tests solid-panes#296)
• Solid-UI (https://github.com/solid/solid-ui/pull/421)
• Rdflib (Fixed typing error linkeddata/rdflib.js#511)

Auth Upgrade includes the following libraries:

• Mashlib: [WIP] Auth Upgrade mashlib#120
• Solid-Panes: [WIP] Auth upgrade solid-panes#297
• Solid-UI: https://github.com/solid/solid-ui/pull/420
• Solid-Logic: [WIP] Auth Upgrade solid-logic#24
• Data-Kitchen: already merged into main, needs mashlib repointed when available
• Node-Solid-Server: [WIP] Auth-Upgrade nodeSolidServer/node-solid-server#1611
• Chat-Pane: [WIP] Auth Upgrade  chat-pane#65
• Money-Pane: [WIP] Auth Upgrade money-pane#43
• Profile-Pane: Auth-upgrade branch for profile-pane profile-pane#17

[bourgeoa]

@jaxoncreed Can I help. I have all access rights including nom publish.

solid/test-suite may be added to your steps ? It is used in NSS CI

I saw your PR's and tried to run solid/solidos lerna beginning step by step on https://alice.localhost:8443

• solid-logic is used in https://github.com/solid/test-suite/web-access-control-tests fails 3 tests on NSS with 403 (./run-against-nss.sh) is there a new trusted-app needed ?
• solid-ui with the new solid-logic fails on a few tests

How do you want me to report this ?

[jaxoncreed]

@bourgeoa Reporting here is fine. I haven't completed the tests yet. They'll need to be updated for this new login.

[jeff-zucker]

@jaxoncreed - What's the best way to test this all? My guess - pull latest solidos, pull your newest mashlib, solid-ui, solid-logic into their respective workspaces under solidos, then build mashlib. If there's an easier or way, please let me know. :-)

[bourgeoa]

@jeff-zucker

My guess - pull latest solidos, pull your newest mashlib, solid-ui, solid-logic into their respective workspaces under solidos, then build mashlib.

you must add solid-panes.
I just build all and there is one error in building solid-panes

src/dashboard/dashboardPane.ts:19:11 - error TS2339: Property 'solidAuthClient' does not exist on type '{ checkUser: <T>(setUserCallback?: ((me: NamedNode | null) => T) | undefined) => Promise<NamedNode | T | null>; currentUser: () => NamedNode | null; ... 18 more ...; authSession: any; }'.

19     authn.solidAuthClient.trackSession(async (session: SolidSession) => {
             ~~~~~~~~~~~~~~~


Found 1 error

I passed that by replacing with authn['solidAuthClient].trackSession(async (session: SolidSession) => {

Build now passes including mashlib
NSS test has 3 errors, but is running.
I'am able to log and use dataBrowser except dashbord

manager.js:506 Uncaught (in promise) TypeError: Cannot read property 'trackSession' of undefined

The above hack is not the solution

[jeff-zucker]

With some help from @bourgeoa, I got the lerna links set and am now able to build the new versions of solid-logic and solid-ui but when I try to build solid-panes, even after the fix Alain showed above, I get these two errors :

src/index.ts:35:13 - error TS2345: Argument of type 'import("/home/jeff/Dropbox/Web/solid/solidos/workspaces/solid-logic/lib/index").SolidLogic' is not assignable to parameter of type 'import("/home/jeff/Dropbox/Web/solid/solidos/workspaces/solid-panes/node_modules/solid-logic/lib/index").SolidLogic'.
  The types of 'chat.profile' are incompatible between these types.
    Type 'import("/home/jeff/Dropbox/Web/solid/solidos/workspaces/solid-logic/lib/profile/ProfileLogic").ProfileLogic' is not assignable to type 'import("/home/jeff/Dropbox/Web/solid/solidos/workspaces/solid-panes/node_modules/solid-logic/lib/profile/ProfileLogic").ProfileLogic'.
      Types have separate declarations of a private property 'findStorage'.

35             UI.solidLogicSingleton
               ~~~~~~~~~~~~~~~~~~~~~~

src/outline/context.ts:18:7 - error TS2322: Type 'import("/home/jeff/Dropbox/Web/solid/solidos/workspaces/solid-panes/node_modules/solid-logic/lib/index").SolidLogic' is not assignable to type 'import("/home/jeff/Dropbox/Web/solid/solidos/workspaces/solid-logic/lib/index").SolidLogic'.
  Types of property 'store' are incompatible.
    Property 'slice' is missing in type 'import("/home/jeff/Dropbox/Web/solid/solidos/workspaces/solid-panes/node_modules/solid-logic/lib/index").LiveStore' but required in type 'import("/home/jeff/Dropbox/Web/solid/solidos/workspaces/solid-logic/lib/index").LiveStore'.

18       logic
         ~~~~~

  ../solid-logic/lib/index.d.ts:23:5
    23     slice: any;
           ~~~~~
    'slice' is declared here.
  ../solid-ui/node_modules/pane-registry/index.d.ts:36:3
    36   logic: SolidLogic
         ~~~~~
    The expected type comes from property 'logic' which is declared here on type 'DataBrowserSession'

[jaxoncreed]

Also note that I have not completed all the tasks yet so there will be errors.

[jeff-zucker]

Okay, no problem, let me know when things are ready to test or if there's errors I might be able to help track down (typescript is not my forte).

[bourgeoa]

@jackson in your integration of solid-client-authn-js-browser you should add solid-panes.

Solid-panes is using : solid-auth-client either as require or via solid-ui.

• https://github.com/solid/solid-panes/blob/4d06479591ef9b9d53acf8196e049384a8919853/dev/loader.ts#L6
• https://github.com/solid/solid-panes/blob/4d06479591ef9b9d53acf8196e049384a8919853/src/dashboard/dashboardPane.ts#L19
• https://github.com/solid/solid-panes/blob/4d06479591ef9b9d53acf8196e049384a8919853/src/outline/manager.js#L506

[jeff-zucker]

I built your latest PRs and ran mashlib in Data-Kitchen. I can login to NSS. With modifications, I can read local containers and resources in the same window. More testing ahead, but looks good so far. Great work!

[jaxoncreed]

Thanks @jeff-zucker . What modifications did you need?

[jeff-zucker]

I'll post a list of them when I'm further along. Basically, I need to have fetcher do a context-sensitive fetch so that it uses solid-client-authn-browser for http(s):// fetches and solid-rest for serverless file-system file:/// fetches. Then I need to make sure that when looking at local files we don't demand a login and use $SolidTestEnvironment.username instead (but only for file fetches) , that will allow us to get a user's local profile and preferenes from local files without calling login. Then various similar things with currentUser so that it treats local file user differently from logged in user but handles both in the same databrowser instance. I am making things as generic as possible so, for example if someone later adds a dropbox:// fetch in their app, it will be picked up and used as a context-sensitve fetch within SolidOS.

If the above doesn't make sense, or there are better ways, let me know.

[jeff-zucker]

@jaxoncreed - Great work, thanks! I got your mashlib working with CSS by using the config in community-server-recipes/mashlib, putting a modified version of browse.html in the CSS root folder and having it point to the location of mashilib.min.js and mash.css.

I will create another branch of Data-Kitchen with my non-server and server versions. Sorry about the mixup, I should have committed my versions two years ago when I began working on them.

Please ping me if there's anything I can do to help.

[bourgeoa]

@jaxoncreed just updated to latest following today's meeting and noticed that :

• logout do not really log you out until you refresh the page. (I was able to edit and save permissions using the sharing-pane after logout)
  I'm using chrome.
• I still have solid-ui "git run test" errors ReferenceError: TextEncoder is not defined with node v16.5, v14.17 or v12.19
  I'm using windows WSL1 to build.