refactor: for suggest review

Author: saseungmin

README.md

@@ -360,9 +360,9 @@ npx code-push release --binary-version 1.0.0 --app-version 1.0.1 \
                       --mandatory true
 
 # Expo project
-npx code-push release --type expo --binary-version 1.0.0 --app-version 1.0.1 --platform ios
+npx code-push release --framework expo --binary-version 1.0.0 --app-version 1.0.1 --platform ios
 ```
-- `--type`: Project type (react-native (default) | expo)
+- `--framework`(`-f`) : Framework type (expo)
 - `--binary-version`: The version of the binary app that the CodePush update is targeting.
 - `--app-version`: The version of the CodePush update itself.
 
@@ -394,12 +394,13 @@ Create a CodePush bundle file.
 npx code-push bundle --platform android --entry-file index.js
 
 # Expo project
-npx code-push bundle --type expo --platform android --entry-file index.js
+npx code-push bundle --framework expo --platform android --entry-file index.js
 ```
-- `--type`: Project type (react-native (default) | expo)
+- `--framework`(`-f`): Framework type (expo)
 
 By default, the bundle file is created in the `/build/bundleOutput` directory.
 
->[!NOTE] For Expo projects, the CLI uses `expo export:embed` command for bundling instead of React Native's bundle command.
+> [!NOTE]
+> For Expo projects, the CLI uses `expo export:embed` command for bundling instead of React Native's bundle command.
 
 (The file name represents a hash value of the bundle content.)

cli/commands/bundleCommand/bundleCodePush.js

@@ -8,7 +8,7 @@ const { makeCodePushBundle } = require('../../functions/makeCodePushBundle');
 const { ROOT_OUTPUT_DIR, ENTRY_FILE } = require('../../constant');
 
 /**
- * @param type {string} 'react-native' | 'expo'
+ * @param framework {string|undefined} 'expo'
  * @param platform {string} 'ios' | 'android'
  * @param outputRootPath {string}
  * @param entryFile {string}
@@ -17,7 +17,7 @@ const { ROOT_OUTPUT_DIR, ENTRY_FILE } = require('../../constant');
  * @return {Promise<string>} CodePush bundle file name (equals to packageHash)
  */
 async function bundleCodePush(
-  type = 'react-native',
+  framework,
   platform = 'ios',
   outputRootPath = ROOT_OUTPUT_DIR,
   entryFile = ENTRY_FILE,
@@ -35,16 +35,16 @@ async function bundleCodePush(
 
     prepareToBundleJS({ deleteDirs: [outputRootPath, getReactTempDir()], makeDir: OUTPUT_CONTENT_PATH });
 
-    if (type === 'react-native') {
-      runReactNativeBundleCommand(
+    if (framework === 'expo') {
+      runExpoBundleCommand(
         _jsBundleName,
         OUTPUT_CONTENT_PATH,
         platform,
         SOURCEMAP_OUTPUT,
         entryFile,
       );
-    } else if (type === 'expo') {
-      runExpoBundleCommand(
+    } else {
+      runReactNativeBundleCommand(
         _jsBundleName,
         OUTPUT_CONTENT_PATH,
         platform,

cli/commands/bundleCommand/index.js

@@ -4,15 +4,15 @@ const { OUTPUT_BUNDLE_DIR, ROOT_OUTPUT_DIR, ENTRY_FILE } = require('../../consta
 
 program.command('bundle')
     .description('Creates a CodePush bundle file (assumes Hermes is enabled).')
-    .addOption(new Option('-t, --type <type>', 'project type (react-native | expo)').choices(['react-native', 'expo']).default('react-native'))
+    .addOption(new Option('-f, --framework <type>', 'framework type (expo)').choices(['expo']))
     .addOption(new Option('-p, --platform <type>', 'platform').choices(['ios', 'android']).default('ios'))
     .option('-o, --output-path <string>', 'path to output root directory', ROOT_OUTPUT_DIR)
     .option('-e, --entry-file <string>', 'path to JS/TS entry file', ENTRY_FILE)
     .option('-b, --bundle-name <string>', 'bundle file name (default-ios: "main.jsbundle" / default-android: "index.android.bundle")')
     .option('--output-bundle-dir <string>', 'name of directory containing the bundle file created by the "bundle" command', OUTPUT_BUNDLE_DIR)
     /**
      * @param {Object} options
-     * @param {string} options.type
+     * @param {string} options.framework
      * @param {string} options.platform
      * @param {string} options.outputPath
      * @param {string} options.entryFile
@@ -22,7 +22,7 @@ program.command('bundle')
      */
     .action((options) => {
         bundleCodePush(
-            options.type,
+            options.framework,
             options.platform,
             options.outputPath,
             options.entryFile,

cli/commands/releaseCommand/index.js

@@ -7,7 +7,7 @@ program.command('release')
     .description('Deploys a new CodePush update for a target binary app.\nAfter creating the CodePush bundle, it uploads the file and updates the ReleaseHistory information.\n`bundleUploader`, `getReleaseHistory`, and `setReleaseHistory` functions should be implemented in the config file.')
     .requiredOption('-b, --binary-version <string>', '(Required) The target binary version')
     .requiredOption('-v, --app-version <string>', '(Required) The app version to be released. It must be greater than the binary version.')
-    .addOption(new Option('-t, --type <type>', 'project type (react-native | expo)').choices(['react-native', 'expo']).default('react-native'))
+    .addOption(new Option('-f, --framework <type>', 'framework type (expo)').choices(['expo']))
     .addOption(new Option('-p, --platform <type>', 'platform').choices(['ios', 'android']).default('ios'))
     .option('-i, --identifier <string>', 'reserved characters to distinguish the release.')
     .option('-c, --config <path>', 'set config file name (JS/TS)', CONFIG_FILE_NAME)
@@ -23,7 +23,7 @@ program.command('release')
      * @param {Object} options
      * @param {string} options.binaryVersion
      * @param {string} options.appVersion
-     * @param {string} options.type
+     * @param {string} options.framework
      * @param {string} options.platform
      * @param {string} options.identifier
      * @param {string} options.config
@@ -46,7 +46,7 @@ program.command('release')
             config.setReleaseHistory,
             options.binaryVersion,
             options.appVersion,
-            options.type,
+            options.framework,
             options.platform,
             options.identifier,
             options.outputPath,

cli/commands/releaseCommand/release.js

@@ -25,7 +25,7 @@ const { addToReleaseHistory } = require("./addToReleaseHistory");
  *   ): Promise<void>}
  * @param binaryVersion {string}
  * @param appVersion {string}
- * @param type {string} 'react-native' | 'expo'
+ * @param framework {string|undefined} 'expo'
  * @param platform {"ios" | "android"}
  * @param identifier {string?}
  * @param outputPath {string}
@@ -44,7 +44,7 @@ async function release(
     setReleaseHistory,
     binaryVersion,
     appVersion,
-    type = 'react-native',
+    framework,
     platform,
     identifier,
     outputPath,
@@ -58,7 +58,7 @@ async function release(
 ) {
     const bundleFileName = skipBundle
         ? readBundleFileNameFrom(bundleDirectory)
-        : await bundleCodePush(type, platform, outputPath, entryFile, jsBundleName, bundleDirectory);
+        : await bundleCodePush(framework, platform, outputPath, entryFile, jsBundleName, bundleDirectory);
     const bundleFilePath = `${bundleDirectory}/${bundleFileName}`;
 
     const downloadUrl = await (async () => {