refactor: migrate cli tools code to TypeScript (#91)

* refactor: migrate cli tools code to TypeScript

* chore: remove unused dependencies

Author: floydkim

.gitignore

@@ -77,33 +77,6 @@ build/Release
 # https://docs.npmjs.com/misc/faq#should-i-check-my-node-modules-folder-into-git
 node_modules
 
-# Xcode
-#
-# gitignore contributors: remember to update Global/Xcode.gitignore, Objective-C.gitignore & Swift.gitignore
-
-## Build generated
-build/
-DerivedData
-
-## Various settings
-*.pbxuser
-!default.pbxuser
-*.mode1v3
-!default.mode1v3
-*.mode2v3
-!default.mode2v3
-*.perspectivev3
-!default.perspectivev3
-xcuserdata
-
-## OSX
-.DS_Store
-
-## Other
-*.xccheckout
-*.moved-aside
-*.xcuserstate
-
 # Intellij project files
 *.iml
 *.ipr
@@ -113,7 +86,7 @@ xcuserdata
 #Gradle
 .gradletasknamecache
 .gradle/
-build/
+*/build/
 bin/
 
 # Built application files
@@ -127,14 +100,8 @@ bin/
 *.class
 
 # Generated files
-bin/
 gen/
 
-# Gradle files
-.gradle/
-build/
-*/build/
-
 # Local configuration file (sdk path, etc)
 local.properties
 
@@ -173,7 +140,6 @@ windows/obj/
 *.bak
 *.[Cc]ache
 *.ilk
-*.log
 *.lib
 *.sbr
 *.sdf
@@ -195,3 +161,11 @@ Examples/testapp_rn
 
 # prevent CLI code ignored (ignored by "[Rr]elease*/")
 !cli/commands/releaseCommand/
+
+# CLI TypeScript build output
+cli/dist/
+
+# Don't ignore CLI executable
+!bin/
+bin/*
+!bin/code-push.js

.npmignore

@@ -1,3 +1,6 @@
 module.exports = {
-    presets: [['@babel/preset-env', {targets: {node: 'current'}}]],
-};
+    presets: [[
+        '@babel/preset-env', {targets: {node: 'current'}}],
+        '@babel/preset-typescript'
+    ],
+};

babel.config.js

@@ -0,0 +1,6 @@
+#!/usr/bin/env node
+
+import('../cli/dist/index.js').catch((error) => {
+  console.error(error);
+  process.exit(1);
+});

bin/code-push.js

@@ -1,29 +1,23 @@
-const fs = require('fs');
-const { prepareToBundleJS } = require('../../functions/prepareToBundleJS');
-const { runReactNativeBundleCommand } = require('../../functions/runReactNativeBundleCommand');
-const { runExpoBundleCommand } = require('../../functions/runExpoBundleCommand');
-const { getReactTempDir } = require('../../functions/getReactTempDir');
-const { runHermesEmitBinaryCommand } = require('../../functions/runHermesEmitBinaryCommand');
-const { makeCodePushBundle } = require('../../functions/makeCodePushBundle');
-const { ROOT_OUTPUT_DIR, ENTRY_FILE } = require('../../constant');
+import fs from "fs";
+import { prepareToBundleJS } from "../../functions/prepareToBundleJS.js";
+import { runReactNativeBundleCommand } from "../../functions/runReactNativeBundleCommand.js";
+import { runExpoBundleCommand } from "../../functions/runExpoBundleCommand.js";
+import { getReactTempDir } from "../../functions/getReactTempDir.js";
+import { runHermesEmitBinaryCommand } from "../../functions/runHermesEmitBinaryCommand.js";
+import { makeCodePushBundle } from "../../functions/makeCodePushBundle.js";
+import { ROOT_OUTPUT_DIR, ENTRY_FILE } from "../../constant.js";
 
 /**
- * @param framework {string|undefined} 'expo'
- * @param platform {string} 'ios' | 'android'
- * @param outputRootPath {string}
- * @param entryFile {string}
- * @param jsBundleName {string|undefined}
- * @param bundleDirectory {string}
  * @return {Promise<string>} CodePush bundle file name (equals to packageHash)
  */
-async function bundleCodePush(
-  framework,
-  platform = 'ios',
-  outputRootPath = ROOT_OUTPUT_DIR,
-  entryFile = ENTRY_FILE,
-  jsBundleName, // JS bundle file name (not CodePush bundle file)
-  bundleDirectory, // CodePush bundle output directory
-) {
+export async function bundleCodePush(
+  framework: 'expo' | undefined,
+  platform: 'ios' | 'android' = 'ios',
+  outputRootPath: string = ROOT_OUTPUT_DIR,
+  entryFile: string = ENTRY_FILE,
+  jsBundleName: string, // JS bundle file name (not CodePush bundle file)
+  bundleDirectory: string, // CodePush bundle output directory
+): Promise<string> {
     if (fs.existsSync(outputRootPath)) {
         fs.rmSync(outputRootPath, { recursive: true });
     }
@@ -67,5 +61,3 @@ async function bundleCodePush(
 
     return codePushBundleFileName;
 }
-
-module.exports = { bundleCodePush: bundleCodePush };

…commands/bundleCommand/bundleCodePush.js …commands/bundleCommand/bundleCodePush.tscli/commands/bundleCommand/bundleCodePush.js renamed to cli/commands/bundleCommand/bundleCodePush.ts cli/commands/bundleCommand/bundleCodePush.js renamed to cli/commands/bundleCommand/bundleCodePush.ts

@@ -1,6 +1,15 @@
-const { program, Option } = require("commander");
-const { bundleCodePush } = require("./bundleCodePush");
-const { OUTPUT_BUNDLE_DIR, ROOT_OUTPUT_DIR, ENTRY_FILE } = require('../../constant');
+import { program, Option } from "commander";
+import { bundleCodePush } from "./bundleCodePush.js";
+import { OUTPUT_BUNDLE_DIR, ROOT_OUTPUT_DIR, ENTRY_FILE } from "../../constant.js";
+
+type Options = {
+    framework: 'expo' | undefined;
+    platform: 'ios' | 'android';
+    outputPath: string;
+    entryFile: string;
+    bundleName: string;
+    outputBundleDir: string;
+}
 
 program.command('bundle')
     .description('Creates a CodePush bundle file (assumes Hermes is enabled).')
@@ -10,17 +19,7 @@ program.command('bundle')
     .option('-e, --entry-file <string>', 'path to JS/TS entry file', ENTRY_FILE)
     .option('-b, --bundle-name <string>', 'bundle file name (default-ios: "main.jsbundle" / default-android: "index.android.bundle")')
     .option('--output-bundle-dir <string>', 'name of directory containing the bundle file created by the "bundle" command', OUTPUT_BUNDLE_DIR)
-    /**
-     * @param {Object} options
-     * @param {string} options.framework
-     * @param {string} options.platform
-     * @param {string} options.outputPath
-     * @param {string} options.entryFile
-     * @param {string} options.bundleName
-     * @param {string} options.outputBundleDir
-     * @return {void}
-     */
-    .action((options) => {
+    .action((options: Options) => {
         bundleCodePush(
             options.framework,
             options.platform,

cli/commands/bundleCommand/index.js cli/commands/bundleCommand/index.tscli/commands/bundleCommand/index.js renamed to cli/commands/bundleCommand/index.ts

@@ -1,36 +1,21 @@
-const fs = require('fs');
-const path = require('path');
+import fs from "fs";
+import path from "path";
+import type { CliConfigInterface, ReleaseHistoryInterface, ReleaseInfo } from "../../../typings/react-native-code-push.d.ts";
 
-/**
- *
- * @param targetVersion {string}
- * @param setReleaseHistory {
- *   function(
- *     targetBinaryVersion: string,
- *     jsonFilePath: string,
- *     releaseInfo: ReleaseHistoryInterface,
- *     platform: string,
- *     identifier: string
- *   ): Promise<void>}
- * @param platform {"ios" | "android"}
- * @param identifier {string}
- * @returns {Promise<void>}
- */
-async function createReleaseHistory(
-    targetVersion,
-    setReleaseHistory,
-    platform,
-    identifier,
-) {
-    const BINARY_RELEASE = {
+export async function createReleaseHistory(
+    targetVersion: string,
+    setReleaseHistory: CliConfigInterface['setReleaseHistory'],
+    platform: 'ios' | 'android',
+    identifier?: string,
+): Promise<void> {
+    const BINARY_RELEASE: ReleaseInfo = {
         enabled: true,
         mandatory: false,
         downloadUrl: "",
         packageHash: "",
     };
 
-    /** @type {ReleaseHistoryInterface} */
-    const INITIAL_HISTORY = {
+    const INITIAL_HISTORY: ReleaseHistoryInterface = {
         [targetVersion]: BINARY_RELEASE
     };
 
@@ -49,5 +34,3 @@ async function createReleaseHistory(
         process.exit(1)
     }
 }
-
-module.exports = { createReleaseHistory: createReleaseHistory }

…teHistoryCommand/createReleaseHistory.js …teHistoryCommand/createReleaseHistory.tscli/commands/createHistoryCommand/createReleaseHistory.js renamed to cli/commands/createHistoryCommand/createReleaseHistory.ts cli/commands/createHistoryCommand/createReleaseHistory.js renamed to cli/commands/createHistoryCommand/createReleaseHistory.ts

@@ -1,23 +1,22 @@
-const { program, Option } = require("commander");
-const { findAndReadConfigFile } = require("../../utils/fsUtils");
-const { createReleaseHistory } = require("./createReleaseHistory");
-const { CONFIG_FILE_NAME } = require('../../constant');
+import { program, Option } from "commander";
+import { findAndReadConfigFile } from "../../utils/fsUtils.js";
+import { createReleaseHistory } from "./createReleaseHistory.js";
+import { CONFIG_FILE_NAME } from "../../constant.js";
+
+type Options = {
+    binaryVersion: string;
+    platform: 'ios' | 'android';
+    identifier?: string;
+    config: string;
+}
 
 program.command('create-history')
     .description('Creates a new release history for the binary app.')
     .requiredOption('-b, --binary-version <string>', '(Required) The target binary version')
     .addOption(new Option('-p, --platform <type>', 'platform').choices(['ios', 'android']).default('ios'))
     .option('-i, --identifier <string>', 'reserved characters to distinguish the release.')
     .option('-c, --config <path>', 'set config file name (JS/TS)', CONFIG_FILE_NAME)
-    /**
-     * @param {Object} options
-     * @param {string} options.binaryVersion
-     * @param {string} options.platform
-     * @param {string} options.identifier
-     * @param {string} options.config
-     * @return {void}
-     */
-    .action(async (options) => {
+    .action(async (options: Options) => {
         const config = findAndReadConfigFile(process.cwd(), options.config);
 
         await createReleaseHistory(

…i/commands/createHistoryCommand/index.js …i/commands/createHistoryCommand/index.tscli/commands/createHistoryCommand/index.js renamed to cli/commands/createHistoryCommand/index.ts cli/commands/createHistoryCommand/index.js renamed to cli/commands/createHistoryCommand/index.ts

@@ -1,6 +1,6 @@
-const { initAndroid } = require('./initAndroid');
-const { initIos } = require('./initIos');
-const { program } = require('commander');
+import { initAndroid } from "./initAndroid.js";
+import { initIos } from "./initIos.js";
+import { program } from "commander";
 
 program
     .command('init')