test(CLI): extract pure functions for appdelegate modification and update tests

Author: floydkim

cli/commands/initCommand/initIos.js

@@ -35,18 +35,32 @@ function findAppDelegate(searchPath) {
     return appDelegateFile ? path.join(searchPath, appDelegateFile) : null;
 }
 
-async function setupObjectiveC(appDelegatePath) {
-    const appDelegateContent = fs.readFileSync(appDelegatePath, 'utf-8');
+function modifyObjectiveCAppDelegate(appDelegateContent) {
     const IMPORT_STATEMENT = '#import <CodePush/CodePush.h>';
     if (appDelegateContent.includes(IMPORT_STATEMENT)) {
         console.log('AppDelegate already has CodePush imported.');
-        return;
+        return appDelegateContent;
     }
 
-    const newContent = appDelegateContent
+    return appDelegateContent
         .replace('#import "AppDelegate.h"\n', `#import "AppDelegate.h"\n${IMPORT_STATEMENT}\n`)
         .replace('[[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];', '[CodePush bundleURL];');
+}
 
+function modifySwiftAppDelegate(appDelegateContent) {
+    const CODEPUSH_CALL_STATEMENT = 'CodePush.bundleURL()';
+    if (appDelegateContent.includes(CODEPUSH_CALL_STATEMENT)) {
+        console.log('AppDelegate.swift already configured for CodePush.');
+        return appDelegateContent;
+    }
+
+    return appDelegateContent
+        .replace('Bundle.main.url(forResource: "main", withExtension: "jsbundle")', CODEPUSH_CALL_STATEMENT);
+}
+
+async function setupObjectiveC(appDelegatePath) {
+    const appDelegateContent = fs.readFileSync(appDelegatePath, 'utf-8');
+    const newContent = modifyObjectiveCAppDelegate(appDelegateContent);
     fs.writeFileSync(appDelegatePath, newContent);
     console.log('Successfully updated AppDelegate.m/mm.');
 }
@@ -59,14 +73,7 @@ async function setupSwift(appDelegatePath, projectDir, projectName) {
     }
 
     const appDelegateContent = fs.readFileSync(appDelegatePath, 'utf-8');
-    const CODEPUSH_CALL_STATEMENT = 'CodePush.bundleURL()';
-    if (appDelegateContent.includes(CODEPUSH_CALL_STATEMENT)) {
-        console.log('AppDelegate.swift already configured for CodePush.');
-        return;
-    }
-
-    const newContent = appDelegateContent
-        .replace('Bundle.main.url(forResource: "main", withExtension: "jsbundle")', CODEPUSH_CALL_STATEMENT);
+    const newContent = modifySwiftAppDelegate(appDelegateContent);
     fs.writeFileSync(appDelegatePath, newContent);
     console.log('Successfully updated AppDelegate.swift.');
 }
@@ -116,4 +123,6 @@ async function ensureBridgingHeader(projectDir, projectName) {
 
 module.exports = {
     initIos: initIos,
+    modifyObjectiveCAppDelegate,
+    modifySwiftAppDelegate,
 }

cli/commands/initCommand/test/initCommandTest.test.js

@@ -0,0 +1,96 @@
+const { modifyObjectiveCAppDelegate, modifySwiftAppDelegate } = require('../initIos');
+
+const swiftTemplate = `
+import UIKit
+import React
+import React_RCTAppDelegate
+import ReactAppDependencyProvider
+
+@main
+class AppDelegate: UIResponder, UIApplicationDelegate {
+  var window: UIWindow?
+  var reactNativeDelegate: ReactNativeDelegate?
+  var reactNativeFactory: RCTReactNativeFactory?
+
+  func application(
+    _ application: UIApplication,
+    didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? = nil
+  ) -> Bool {
+    let delegate = ReactNativeDelegate()
+    let factory = RCTReactNativeFactory(delegate: delegate)
+    delegate.dependencyProvider = RCTAppDependencyProvider()
+    reactNativeDelegate = delegate
+    reactNativeFactory = factory
+    window = UIWindow(frame: UIScreen.main.bounds)
+    factory.startReactNative(
+      withModuleName: "HelloWorld",
+      in: window,
+      launchOptions: launchOptions
+    )
+    return true
+  }
+}
+
+class ReactNativeDelegate: RCTDefaultReactNativeFactoryDelegate {
+  override func sourceURL(for bridge: RCTBridge) -> URL? {
+    self.bundleURL()
+  }
+
+  override func bundleURL() -> URL? {
+    #if DEBUG
+    RCTBundleURLProvider.sharedSettings().jsBundleURL(forBundleRoot: "index")
+    #else
+    Bundle.main.url(forResource: "main", withExtension: "jsbundle")
+    #endif
+  }
+}
+`;
+
+const objcTemplate = `
+#import "AppDelegate.h"
+
+#import <React/RCTBundleURLProvider.h>
+
+@implementation AppDelegate
+
+- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
+{
+  self.moduleName = @"HelloWorld";
+  // You can add your custom initial props in the dictionary below.
+  // They will be passed down to the ViewController used by React Native.
+  self.initialProps = @{};
+
+  return [super application:application didFinishLaunchingWithOptions:launchOptions];
+}
+
+- (NSURL *)sourceURLForBridge:(RCTBridge *)bridge
+{
+  return [self bundleURL];
+}
+
+- (NSURL *)bundleURL
+{
+#if DEBUG
+  return [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"index"];
+#else
+  return [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];
+#endif
+}
+
+@end
+`;
+
+describe('iOS init command - pure functions', () => {
+  it('should correctly modify Swift AppDelegate content', () => {
+    const modifiedContent = modifySwiftAppDelegate(swiftTemplate);
+    expect(modifiedContent).toContain('CodePush.bundleURL()');
+    expect(modifiedContent).not.toContain('Bundle.main.url(forResource: "main", withExtension: "jsbundle")');
+  });
+
+  it('should correctly modify Objective-C AppDelegate content', () => {
+    const modifiedContent = modifyObjectiveCAppDelegate(objcTemplate);
+    expect(modifiedContent).toContain('#import <CodePush/CodePush.h>');
+    expect(modifiedContent).toContain('[CodePush bundleURL]');
+    expect(modifiedContent).not.toContain('[[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];');
+  });
+});