Skip to content

Commit bcc3a0e

Browse files
committed
Merge branch 'master' into v10
# Conflicts: # CodePush.js # README.md # package-lock.json # package.json
2 parents 474210a + 932410b commit bcc3a0e

File tree

2 files changed

+11
-15
lines changed

2 files changed

+11
-15
lines changed

CodePush.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -253,11 +253,11 @@ async function tryReportStatus(statusReport, retryOnAppResume) {
253253
const label = statusReport.package.label;
254254
if (statusReport.status === "DeploymentSucceeded") {
255255
log(`Reporting CodePush update success (${label})`);
256-
sharedCodePushOptions?.onUpdateSuccess(label);
256+
sharedCodePushOptions?.onUpdateSuccess?.(label);
257257
} else {
258258
log(`Reporting CodePush update rollback (${label})`);
259259
await NativeCodePush.setLatestRollbackInfo(statusReport.package.packageHash);
260-
sharedCodePushOptions?.onUpdateRollback(label);
260+
sharedCodePushOptions?.onUpdateRollback?.(label);
261261
}
262262
}
263263

@@ -564,7 +564,7 @@ async function syncInternal(options = {}, syncStatusChangeCallback, downloadProg
564564
}
565565
} catch (error) {
566566
syncStatusChangeCallback(CodePush.SyncStatus.UNKNOWN_ERROR);
567-
sharedCodePushOptions?.onSyncError(remotePackageLabel ?? 'unknown', error);
567+
sharedCodePushOptions?.onSyncError?.(remotePackageLabel ?? 'unknown', error);
568568
log(error.message);
569569
throw error;
570570
}

README.md

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,10 @@
11
# @bravemobile/react-native-code-push
22

3-
**Seamless transition from AppCenter to a fully self-hosted CodePush.**
4-
5-
6-
This package was created to continue using React Native CodePush without AppCenter.
7-
8-
It allows self-hosting of CodePush deployments while retaining essential operational features.
9-
10-
3+
### Seamless Transition from AppCenter to a Fully Self-Hosted CodePush
114

5+
- **No API Server Needed** – Use static hosting solutions (e.g., AWS S3) without maintaining additional API servers.
6+
- **Familiar API** – Built on `microsoft/react-native-code-push`, ensuring compatibility and stability.
7+
- **Flexible Deployment** – Implement your own release workflow, giving you complete control over the deployment process.
128

139
### 🚀 New Architecture support
1410

@@ -367,15 +363,15 @@ Release a CodePush update for a specific binary app version.
367363
- Release a CodePush update `1.0.1` targeting the binary app version `1.0.0`.
368364

369365
```
370-
npx code-push release --target-binary-version 1.0.0 --app-version 1.0.1 \
366+
npx code-push release --binary-version 1.0.0 --app-version 1.0.1 \
371367
--platform ios --identifier staging --entry-file index.js \
372368
--mandatory true
373369
```
374-
- `--target-binary-version`: The version of the binary app that the CodePush update is targeting.
370+
- `--binary-version`: The version of the binary app that the CodePush update is targeting.
375371
- `--app-version`: The version of the CodePush update itself.
376372

377373
> [!IMPORTANT]
378-
> `--app-version` should be greater than `--target-binary-version` (SemVer comparison).
374+
> `--app-version` should be greater than `--binary-version` (SemVer comparison).
379375
380376

381377
#### `update-history`
@@ -388,7 +384,7 @@ Update the release history for a specific CodePush update.
388384
- Rollback the CodePush update `1.0.1` (targeting the binary app version `1.0.0`).
389385

390386
```
391-
npx code-push update-history --target-binary-version 1.0.0 --app-version 1.0.1 \
387+
npx code-push update-history --binary-version 1.0.0 --app-version 1.0.1 \
392388
--platform ios --identifier staging \
393389
--enable false
394390
```

0 commit comments

Comments
 (0)