Merge pull request #77 from Soomgo-Mobile/v11-drop-73

mod!: simplify and remove legacy code for RN 0.73

Author: floydkim

README.md

@@ -8,17 +8,9 @@
 
 ### 🚀 New Architecture support
 
-Tested on the React Native template apps
-
-| RN Version | Old Architecture | New Architecture | New Architecture Bridgeless |
-|--------|--------|--------|--------|
-| 0.73.11 | ✅ | ✅ | Unsupported |
-| 0.74.7 | ✅ | ✅ | ✅ |
-| 0.75.5 | ✅ | ✅ | ✅ |
-| 0.76.7 | ✅ | ✅ | ✅ |
-| 0.77.1 | ✅ | ✅ | ✅ | 
-| 0.78.0 | ✅ | ✅ | ✅ | 
+Supports React Native 0.74 ~ 0.80.
 
+(Tested on the React Native CLI template apps)
 
 ## 🚗 Migration Guide
 

android/app/proguard-rules.pro

@@ -24,10 +24,6 @@
     private ** mReactHost; # bridgeless
     public void reload(...); # RN 0.74 and above
 }
-# RN 0.74 and above
--keepclassmembers class com.facebook.react.ReactActivity {
-    public ** getReactDelegate(...);
-}
 # bridgeless
 -keepclassmembers class com.facebook.react.defaults.DefaultReactHostDelegate {
     private ** jsBundleLoader;

android/app/src/main/java/com/microsoft/codepush/react/CodePushNativeModule.java

@@ -128,7 +128,7 @@ private void setJSBundle(ReactInstanceManager instanceManager, String latestJSBu
 
             ReactHost reactHost = resolveReactHost();
             if (reactHost == null) {
-                // Bridge, Old Architecture and RN < 0.74 (we support Bridgeless >= 0.74)
+                // Bridge, Old Architecture
                 setJSBundleLoaderBridge(instanceManager, latestJSBundleLoader);
                 return;
             }
@@ -184,29 +184,14 @@ private void loadBundle() {
             new Handler(Looper.getMainLooper()).post(new Runnable() {
                 @Override
                 public void run() {
-                    try {
-                        // reload method introduced in RN 0.74 (https://github.com/reactwg/react-native-new-architecture/discussions/174)
-                        // so, we need to check if reload method exists and call it
-                        try {
-                            ReactDelegate reactDelegate = resolveReactDelegate();
-                            if (reactDelegate == null) {
-                                throw new NoSuchMethodException("ReactDelegate doesn't have reload method in RN < 0.74");
-                            }
+                    ReactDelegate reactDelegate = resolveReactDelegate();
+                    assert reactDelegate != null;
 
-                            resetReactRootViews(reactDelegate);
+                    resetReactRootViews(reactDelegate);
 
-                            Method reloadMethod = reactDelegate.getClass().getMethod("reload");
-                            reloadMethod.invoke(reactDelegate);
-                        } catch (NoSuchMethodException e) {
-                            // RN < 0.74 calls ReactInstanceManager.recreateReactContextInBackground() directly
-                            instanceManager.recreateReactContextInBackground();
-                        }
-                        mCodePush.initializeUpdateAfterRestart();
-                    } catch (Exception e) {
-                        // The recreation method threw an unknown exception
-                        // so just simply fallback to restarting the Activity (if it exists)
-                        loadBundleLegacy();
-                    }
+                    reactDelegate.reload();
+
+                    mCodePush.initializeUpdateAfterRestart();
                 }
             });
 
@@ -247,13 +232,7 @@ private ReactDelegate resolveReactDelegate() {
             return null;
         }
 
-        try {
-            Method getReactDelegateMethod = currentActivity.getClass().getMethod("getReactDelegate");
-            return (ReactDelegate) getReactDelegateMethod.invoke(currentActivity);
-        } catch (Exception e) {
-            // RN < 0.74 doesn't have getReactDelegate method
-            return null;
-        }
+        return currentActivity.getReactDelegate();
     }
 
     private ReactHost resolveReactHost() {