From b9aa2397e41fdd34c731943049a0863f23123f4f Mon Sep 17 00:00:00 2001 From: 3446798488 <3446798488@qq.com> Date: Fri, 17 May 2024 03:21:14 +0000 Subject: [PATCH 1/6] fix(destory): fixed event binding not unbinding --- src/Sortable.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Sortable.js b/src/Sortable.js index 81ff84494..1646dcaa1 100644 --- a/src/Sortable.js +++ b/src/Sortable.js @@ -429,10 +429,10 @@ function Sortable(el, options) { on(el, 'mousedown', this._onTapStart); on(el, 'touchstart', this._onTapStart); } - + this._handleEvent = this.handleEvent.bind(this) if (this.nativeDraggable) { - on(el, 'dragover', this); - on(el, 'dragenter', this); + on(el, 'dragover', this._handleEvent); + on(el, 'dragenter', this._handleEvent); } sortables.push(this.el); @@ -1678,8 +1678,8 @@ Sortable.prototype = /** @lends Sortable.prototype */ { off(el, 'pointerdown', this._onTapStart); if (this.nativeDraggable) { - off(el, 'dragover', this); - off(el, 'dragenter', this); + off(el, 'dragover', this._handleEvent); + off(el, 'dragenter', this._handleEvent); } // Remove draggable attributes Array.prototype.forEach.call(el.querySelectorAll('[draggable]'), function (el) { From caff8d735044f828341347bed0c5540bf75f282c Mon Sep 17 00:00:00 2001 From: 3446798488 <3446798488@qq.com> Date: Fri, 17 May 2024 07:52:59 +0000 Subject: [PATCH 2/6] chore(circle): update circle's node image version --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index ffbb4f1a7..e88dcbce9 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -2,7 +2,7 @@ version: 2.0 jobs: build: docker: - - image: circleci/node:10.16-browsers + - image: circleci/node:16.20.2-browsers steps: - checkout From ad857cf97aca186cd0bbf25164554256ad7b7d6d Mon Sep 17 00:00:00 2001 From: 3446798488 <3446798488@qq.com> Date: Fri, 17 May 2024 08:04:03 +0000 Subject: [PATCH 3/6] chore: upgrade to a next-gen Docker image --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index e88dcbce9..8345e89b3 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -2,7 +2,7 @@ version: 2.0 jobs: build: docker: - - image: circleci/node:16.20.2-browsers + - image: cimg/node:16.20.2-browsers steps: - checkout From 8d95d3fbd1b92115930f35306fdc3bdcc1cb419e Mon Sep 17 00:00:00 2001 From: 3446798488 <3446798488@qq.com> Date: Fri, 17 May 2024 08:14:33 +0000 Subject: [PATCH 4/6] chore(circle): add browser-tools --- .circleci/config.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 8345e89b3..256a89fd2 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -1,11 +1,17 @@ version: 2.0 +orbs: + browser-tools: circleci/browser-tools@1.1.0 jobs: build: docker: - image: cimg/node:16.20.2-browsers steps: + - browser-tools/install-browser-tools - checkout - + - run: | + node --version + java --version + google-chrome --version - restore_cache: keys: - v1-dependencies-{{ checksum "package.json" }} From 569de679df64885ac1fb2a54625d73018130d23a Mon Sep 17 00:00:00 2001 From: 3446798488 <3446798488@qq.com> Date: Fri, 17 May 2024 08:16:10 +0000 Subject: [PATCH 5/6] chore(circle): update circle version --- .circleci/config.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 256a89fd2..5a88e4bf0 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -1,6 +1,6 @@ -version: 2.0 +version: 2.1 orbs: - browser-tools: circleci/browser-tools@1.1.0 + browser-tools: circleci/browser-tools@1.4.8 jobs: build: docker: From 865289ccc5d9c1e872a4ab6ad2c0baf7c66147b5 Mon Sep 17 00:00:00 2001 From: 3446798488 <3446798488@qq.com> Date: Fri, 17 May 2024 08:35:45 +0000 Subject: [PATCH 6/6] chore(testcafe): update versions for testcafe --- package.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index 2685b9f94..2f6bc107f 100644 --- a/package.json +++ b/package.json @@ -10,9 +10,9 @@ "rollup-plugin-babel": "^4.3.2", "rollup-plugin-json": "^4.0.0", "rollup-plugin-node-resolve": "^5.0.0", - "testcafe": "^1.3.1", - "testcafe-browser-provider-saucelabs": "^1.7.0", - "testcafe-reporter-xunit": "^2.1.0", + "testcafe": "^3.6.0", + "testcafe-browser-provider-saucelabs": "^3.0.0", + "testcafe-reporter-xunit": "^2.2.3", "uglify-js": "^3.5.12" }, "description": "JavaScript library for reorderable drag-and-drop lists on modern browsers and touch devices. No jQuery required. Supports Meteor, AngularJS, React, Polymer, Vue, Knockout and any CSS library, e.g. Bootstrap.",