Skip to content

Commit b88ddcb

Browse files
committed
Respond to review
1 parent baf1287 commit b88ddcb

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

src/spikeinterface/extractors/neoextractors/intan.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ class IntanRecordingExtractor(NeoBaseRecordingExtractor):
2727
If True, data that violates integrity assumptions will be loaded. At the moment the only integrity
2828
check we perform is that timestamps are continuous. Setting this to True will ignore this check and set
2929
the attribute `discontinuous_timestamps` to True in the underlying neo object.
30-
use_names_as_ids : bool or None, default: None
31-
If True, use channel names as IDs. If None, use default IDs.
30+
use_names_as_ids : bool, default: False
31+
If True, use channel names as IDs. If False, use default IDs inherited from neo.
3232
"""
3333

3434
mode = "file"

src/spikeinterface/extractors/toy_example.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,13 @@ def toy_example(
6262
seed : int or None, default: None
6363
Seed for random initialization.
6464
upsample_factor : None or int, default: None
65-
A upsampling factor used only when templates are not provided.
65+
An upsampling factor, used only when templates are not provided.
6666
num_columns : int, default: 1
6767
Number of columns in probe.
6868
average_peak_amplitude : float, default: -100
69-
Average peak amplitude of generated templates
69+
Average peak amplitude of generated templates.
7070
contact_spacing_um : float, default: 40.0
71-
Spacing between probe contacts.
71+
Spacing between probe contacts in micrometers.
7272
7373
Returns
7474
-------

src/spikeinterface/preprocessing/filter.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111
_common_filter_docs = """**filter_kwargs : dict
1212
Certain keyword arguments for `scipy.signal` filters:
1313
filter_order : order
14-
The order of the filter
14+
The order of the filter. Note as filtering is applied with scipy's
15+
`filtfilt` functions (i.e. acausal, zero-phase) the effective
16+
order will be double the `filter_order`.
1517
filter_mode : "sos" | "ba", default: "sos"
1618
Filter form of the filter coefficients:
1719
- second-order sections ("sos")

0 commit comments

Comments
 (0)