feat: refactor some deprecated osmdroid methods

Author: Splicer97

android/src/main/java/com/osmdroid/OsmMapCalloutManager.java

@@ -1,5 +1,7 @@
 package com.osmdroid;
 
+import androidx.annotation.NonNull;
+
 import com.osmdroid.utils.SizeReportingShadowNode;
 import com.facebook.react.common.MapBuilder;
 import com.facebook.react.uimanager.LayoutShadowNode;
@@ -19,7 +21,7 @@ public String getName() {
     }
 
     @Override
-    public OsmMapCallout createViewInstance(ThemedReactContext context) {
+    public OsmMapCallout createViewInstance(@NonNull ThemedReactContext context) {
         return new OsmMapCallout(context);
     }
 

android/src/main/java/com/osmdroid/OsmMapCircleManager.java

@@ -65,9 +65,5 @@ public void setStrokeColor(OsmMapCircle view, int color) {
     view.setStrokeColor(color);
   }
 
-//  @ReactProp(name = "zIndex", defaultFloat = 1.0f)
-//  public void setZIndex(OSMMapCircle view, float zIndex) {
-//    view.setZIndex(zIndex);
-//  }
 
 }

android/src/main/java/com/osmdroid/OsmMapFileTile.java

@@ -17,16 +17,6 @@
 import java.util.List;
 import java.util.Set;
 
-/**
- * Allows to use offline tile source
- *
- * - Put zip file(s) in internal memory: /data/data/{packageName}/files/offline_tiles/
- * - Internal file subdirectory (offline_tiles) may be changed with setFileDirPath or fileDirPath in
- * js.
- * - Every zip must have same root directory, with same name as others: {ROOT_DIR_NAME}/z/X/Y
- * - Remember to remove hidden os related garbage (like .DS_Store etc.) before creating zip
- * - Zip files may have any name
- */
 public class OsmMapFileTile extends OsmMapFeature {
 
   private final static String TAG = "OsmMapFileTile";
@@ -42,12 +32,10 @@ public OsmMapFileTile(Context context) {
   @Override public void addToMap(MapView map) {
     setupMapProvider(map);
     map.setUseDataConnection(false);
-    // map.setTilesScaledToDpi(false);
   }
 
   @Override public void removeFromMap(MapView map) {
     map.setTileSource(TileSourceFactory.DEFAULT_TILE_SOURCE);
-    // map.setTilesScaledToDpi(false);
   }
 
   @Override public Object getFeature() {

android/src/main/java/com/osmdroid/OsmMapView.java

@@ -111,8 +111,6 @@ public boolean onScroll(MotionEvent e1, MotionEvent e2, float distanceX,
 
         eventDispatcher = reactContext.getNativeModule(UIManagerModule.class).getEventDispatcher();
         this.setTileSource(TileSourceFactory.DEFAULT_TILE_SOURCE);
-        // this.setTilesScaledToDpi(false);
-        // this.setTilesScaleFactor(1);
         this.getZoomController().setVisibility(CustomZoomButtonsController.Visibility.NEVER);
     }
 

android/src/main/java/com/osmdroid/OsmdroidPackage.java

@@ -6,7 +6,6 @@
 import com.facebook.react.uimanager.ViewManager;
 
 import java.util.Arrays;
-import java.util.Collections;
 import java.util.List;
 
 public class OsmdroidPackage implements ReactPackage {

android/src/main/java/com/osmdroid/utils/ImageReader.java

@@ -3,7 +3,6 @@
 import android.content.Context;
 import android.content.res.Resources;
 import android.graphics.Bitmap;
-import android.graphics.BitmapFactory;
 import android.graphics.drawable.Animatable;
 import android.net.Uri;
 

android/src/main/java/com/osmdroid/utils/LatLngBoundsUtils.java

@@ -5,17 +5,17 @@
 
 public class LatLngBoundsUtils {
     public static boolean BoundsAreDifferent(BoundingBox a, BoundingBox b) {
-        GeoPoint centerA = a.getCenter();
+        GeoPoint centerA = a.getCenterWithDateLine();
         double latA = centerA.getLatitude();
         double lngA = centerA.getLongitude();
         double latDeltaA = a.getLatitudeSpan();
-        double lngDeltaA = a.getLongitudeSpan();
+        double lngDeltaA = a.getLongitudeSpanWithDateLine();
 
-        GeoPoint centerB = b.getCenter();
+        GeoPoint centerB = b.getCenterWithDateLine();
         double latB = centerB.getLatitude();
         double lngB = centerB.getLongitude();
         double latDeltaB = b.getLatitudeSpan();
-        double lngDeltaB = b.getLongitudeSpan();
+        double lngDeltaB = b.getLongitudeSpanWithDateLine();
 
         double latEps = LatitudeEpsilon(a, b);
         double lngEps = LongitudeEpsilon(a, b);
@@ -39,8 +39,8 @@ private static double LatitudeEpsilon(BoundingBox a, BoundingBox b) {
     }
 
     private static double LongitudeEpsilon(BoundingBox a, BoundingBox b) {
-        double sizeA = a.getLongitudeSpan();
-        double sizeB = b.getLongitudeSpan();
+        double sizeA = a.getLongitudeSpanWithDateLine();
+        double sizeB = b.getLongitudeSpanWithDateLine();
         double size = Math.min(Math.abs(sizeA), Math.abs(sizeB));
         return size / 2560;
     }

android/src/main/java/com/osmdroid/utils/SizeReportingShadowNode.java

@@ -1,10 +1,3 @@
-/**
- * Copyright (c) 2015-present, Facebook, Inc.
- * All rights reserved.
- * This source code is licensed under the BSD-style license found in the
- * LICENSE file in the root directory of this source tree. An additional grant
- * of patent rights can be found in the PATENTS file in the same directory.
- */
 
 package com.osmdroid.utils;
 

example/src/App.tsx

@@ -32,10 +32,15 @@ export default function App() {
   return (
     <View style={{ flex: 1, position: 'relative' }}>
       <MapView.Animated
-        // tileDownloadThreads={12}
         ref={mapRef}
         style={styles.container}
         initialRegion={initialRegion}
+        onRegionChange={(event) => {
+          console.log('🚀 ~ file: App.tsx:117 ~ App ~ onRegionChange:', event);
+        }}
+        onRegionChangeComplete={(event) => {
+          console.log('🚀 ~ file: App.tsx:117 ~ App ~ onRegionChange:', event);
+        }}
       >
         <Marker
           coordinate={{