Just pushed in f7bd03a and came across a weird instance. Apparently, we previously created XDLTypes and then added them to the type array in the constructor. Is there a particular reason why we decided to do this in the constructor of adding them externally? Only asking because the syntax looked something like types.add(this) and XDLType::classInit was filled with lines resembling new U8(). Seems like it would have been easy to end up with a dangling reference if something bad ever happened to the types array.
Just pushed in f7bd03a and came across a weird instance. Apparently, we previously created XDLTypes and then added them to the type array in the constructor. Is there a particular reason why we decided to do this in the constructor of adding them externally? Only asking because the syntax looked something like
types.add(this)andXDLType::classInitwas filled with lines resemblingnew U8(). Seems like it would have been easy to end up with a dangling reference if something bad ever happened to the types array.