diff --git a/.github/workflows/sonarcloud-analysis.yml b/.github/workflows/sonarqube-analysis.yml similarity index 78% rename from .github/workflows/sonarcloud-analysis.yml rename to .github/workflows/sonarqube-analysis.yml index f15ea46..fe93703 100644 --- a/.github/workflows/sonarcloud-analysis.yml +++ b/.github/workflows/sonarqube-analysis.yml @@ -23,14 +23,17 @@ jobs: if: ${{ github.actor != 'dependabot[bot]' }} steps: - - name: Analyze with SonarCloud - - uses: SonarSource/sonarcloud-github-action@v5.0.0 + - uses: actions/checkout@v5 + with: + fetch-depth: 0 + - name: SonarQube Scan + uses: SonarSource/sonarqube-scan-action@v5.3.0 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} # Needed to post analysis with: args: - # mandatory -Dsonar.projectKey=StrategFirst_BingWall -Dsonar.organization=strategfirst + -Dsonar.sources=scrap,web + diff --git a/README.md b/README.md index 10ffdb7..2c59fd2 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@
-### 4.7.2 +### 4.7.4 # BingWall diff --git a/scrap/index.js b/scrap/index.js index d287df0..ee7b150 100644 --- a/scrap/index.js +++ b/scrap/index.js @@ -19,6 +19,8 @@ class BingWallError extends Error { * Download from the given `webURL` a file and * write it to `localPath` * + * Be aware that no header are injected for this ! + * * JSDoc : * * @param {Document} webURL @@ -56,7 +58,7 @@ async function get_GPS( origin_DOM, origin_HTML ) { // Get the linked page : let GPS_coord = await fetch( `https://bing.com${location_path}`, - {headers: {'User-Agent': 'NodeJS'}} + {headers: {'User-Agent': 'Now/You See/Me2'}} ) .then( res => res.text() ) .then( txt => parse(txt) ) @@ -157,7 +159,7 @@ async function TodayMetadata() { // Grab the page content const HTMLPage = await fetch( `https://www.bing.com?cc=${country.code}`, - {headers: {'User-Agent': 'NodeJS'}} + {headers: {'User-Agent': 'Now/You See/Me2'}} ).then( res => res.text() ); // Use metadata finder : diff --git a/scrap/package-lock.json b/scrap/package-lock.json index d1658f7..5b219a7 100644 --- a/scrap/package-lock.json +++ b/scrap/package-lock.json @@ -1,12 +1,12 @@ { "name": "botwallbing", - "version": "4.7.3", + "version": "4.7.4", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "botwallbing", - "version": "4.7.3", + "version": "4.7.4", "dependencies": { "node-html-parser": "^7.0.1" } diff --git a/scrap/package.json b/scrap/package.json index 43f45bf..f6b290b 100644 --- a/scrap/package.json +++ b/scrap/package.json @@ -1,6 +1,6 @@ { "name": "botwallbing", - "version": "4.7.3", + "version": "4.7.4", "type": "module", "dependencies": { "node-html-parser": "^7.0.1" diff --git a/web/scripts/loader.js b/web/scripts/loader.js index 2a1a100..a825ef5 100644 --- a/web/scripts/loader.js +++ b/web/scripts/loader.js @@ -42,7 +42,12 @@ function toPanelDom( path, name ) { txt_dom += ``; if(md.gps != null) { - let titleCleans = [... md.titles.values()].filter( title => !(title.match(/^Info$/i)) )[0] + let titleCleans = [... md.titles.values()].filter( title => !(title.match(/^Info$/i)) )[0]; + if( titleCleans == undefined ) { + titleCleans = 'Missing Clean Title'; + console.warn('Missing clean title'); + console.trace(); + } let marker_ref_id = addMarker( md.gps.lat, md.gps.long, @@ -257,4 +262,4 @@ async function main() { } } -main() \ No newline at end of file +main()