How to support puppeteer 24.x in Grover

[wgwz]

Hi there 👋 I was wondering what would need to happen to support puppeteer 24.x in Grover.
I'm not familiar with how grover works (yet) but I'm interested in understanding better what it takes to perform the upgrade.

I was looking at the puppeteer changelog and they highlight some breaking changes:
https://pptr.dev/CHANGELOG#2400-2025-01-09

The breaking changes:

• remove support for Firefox over CDP (#13427)
• remove deprecated Launch and Connect options (#13426)
• include URL fragment into URL returned by HTTPRequest/Response instances (#13425)

Where are the places in grover that would need to be updated? It seems like the most likely issue is the launch and connect options.

[abrom]

hi @wgwz

It's not clear from your issue what the problem is? You've reference deprecations to the launch and connect option TYPES, but that doesn't have any affect on non-typed code (like Grover).

As far as I'm aware there is no incompatibility with Grover@latest + Puppeteer@24.x

Have you tried installing and using Puppeteer@24.x with Grover?

To answer your question more directly..

<package manager of choice> install puppeteer@24.8.2

should work just fine 😉

[Petercopter]

We are using Puppeteer 24.x with Grover and have not noticed any issues.

[wgwz]

@abrom thanks for the info! sorry for the delay in my response. tbh, i forgot exactly what led me down this path 😆 but i think it may have been that i misinterpreted the version specifier in the package.json to mean pinned to puppeteer 23.x.
https://github.com/Studiosity/grover/blob/main/package.json#L21

[artur79]

I can confirm that in my setup, a bit specific one, rails 8, grover 1.2.3. What is important I render header and footer separately and that may be the issue:

Rails.application.config.to_prepare do
  Grover.configuration.options[:header_template] = 
    ApplicationController.render(partial: 'layouts/pdf/header').html_safe
  Grover.configuration.options[:footer_template] = 
    ApplicationController.render(partial: 'layouts/pdf/footer').html_safe
end

puppeter "^23.8.0" works fine but 24 not, renders pdf but looks like it's missing css

[abrom]

it's hard to say what's going on there without seeing more specifics of what it in the partial you're rendering. Because of the way Chrome renders the headers/footers there is isolation between the page content and header/footer. As such if you're not including the specific styles in the rendered header/footer then they won't show up. I'm also pretty sure the renderer within Chrome for the header/footer doesn't fetch external sources (CSS) so those would need to be rendered inline in the template. HTH