From 165459b1b290493f556f619ff5510e08b78824a3 Mon Sep 17 00:00:00 2001 From: Gretch Gapol Date: Mon, 17 Oct 2022 16:34:20 +1100 Subject: [PATCH 1/2] :wrench: Support pipe: true setting --- lib/grover/js/processor.cjs | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/grover/js/processor.cjs b/lib/grover/js/processor.cjs index d961738..6eafd97 100644 --- a/lib/grover/js/processor.cjs +++ b/lib/grover/js/processor.cjs @@ -14,6 +14,7 @@ const _processPage = (async (convertAction, urlOrHtml, options) => { let browser, errors = []; try { const launchParams = { + pipe: options.pipe, args: process.env.GROVER_NO_SANDBOX === 'true' ? ['--no-sandbox', '--disable-setuid-sandbox'] : [] }; From b36761d34fb44f38a648545f51da00b444017d75 Mon Sep 17 00:00:00 2001 From: Gretch Gapol Date: Mon, 17 Oct 2022 16:34:20 +1100 Subject: [PATCH 2/2] :wrench: Support pipe: true setting --- lib/grover/js/processor.cjs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/grover/js/processor.cjs b/lib/grover/js/processor.cjs index 6eafd97..fe5f793 100644 --- a/lib/grover/js/processor.cjs +++ b/lib/grover/js/processor.cjs @@ -14,10 +14,15 @@ const _processPage = (async (convertAction, urlOrHtml, options) => { let browser, errors = []; try { const launchParams = { - pipe: options.pipe, args: process.env.GROVER_NO_SANDBOX === 'true' ? ['--no-sandbox', '--disable-setuid-sandbox'] : [] }; + // Configure puppeteer pipe options + const pipe = options.pipe; delete options.pipe; + if (pipe) { + launchParams.pipe = pipe; + } + // Configure puppeteer debugging options const debug = options.debug; delete options.debug; if (typeof debug === 'object' && !!debug) {