From 2151f7098ae84242acf83aa68e3acb8b5d5a35ae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Witek?= Date: Fri, 5 Jul 2024 20:35:33 +0000 Subject: [PATCH] fix: introduce ignoreDefaultArgs into launchParams --- lib/grover/js/processor.cjs | 5 +++++ spec/grover/processor_spec.rb | 21 +++++++++++++++++++++ 2 files changed, 26 insertions(+) diff --git a/lib/grover/js/processor.cjs b/lib/grover/js/processor.cjs index 587498db..79cbff40 100644 --- a/lib/grover/js/processor.cjs +++ b/lib/grover/js/processor.cjs @@ -74,6 +74,11 @@ const _processPage = (async (convertAction, uriOrHtml, options) => { launchParams.executablePath = executablePath; } + // ignoreDefaultArgs + if (options.ignoreDefaultArgs) { + launchParams.ignoreDefaultArgs = options.ignoreDefaultArgs; + } + // Launch the browser and create a page browser = await puppeteer.launch(launchParams); } diff --git a/spec/grover/processor_spec.rb b/spec/grover/processor_spec.rb index ac02d55c..ac413661 100644 --- a/spec/grover/processor_spec.rb +++ b/spec/grover/processor_spec.rb @@ -428,6 +428,27 @@ end end + context 'when options include ignoreDefaultArgs' do + context 'when --disable-component-update is provided' do + let(:options) { { 'ignoreDefaultArgs' => ['--disable-component-update'] } } + let(:url_or_html) do + <<-HTML + + +

+ Testgetriebene Entwicklung ist eine Methode. +

+ + + HTML + end + + it do + expect(pdf_text_content).to eq 'Testgetriebene Ent‐ wicklung ist eine Methode.' + end + end + end + context 'when requesting a URI requiring basic authentication' do let(:url_or_html) { 'http://localhost:4567/auth' }