Add the option to mark users as deleted instead of actually deleting them from the DB

[Theophile-Madet]

Sometimes ShareOwners get created by mistake (typically, they get created twice). For now, a dev has to do deletions manually on the live instance.

We could instead allow marking members as deleted and hide them from all relevant places. This way we reduce the risk of errors, and have a history.

[crosspolar]

@Theophile-Madet : I'm a bit confused because I see end_dates of ShareOwnerShip. Would you consider this to be resolved then?

[Theophile-Madet]

They are different things:

• a user marked deleted should not be shown anywhere, we would just keep it in the DB so that the logs are still there and we can re-trace changes if necessary. That would only be to fix mistakes or bugs.
• a user who's share_ownership have ended is someone who was a member but is not anymore, they should still appear in lists and should not get deleted.

[crosspolar]

I'm still a bit confused: Should there be a button to delete share-owners? And if so, who should be able to push it? Who should be able to restore users?

[Theophile-Madet]

Should there be a button to delete share-owners?

Well yes, otherwise how could we mark them as deleted?

And if so, who should be able to push it?

I would say Employees and Vorstand is enough to let them correct mistakes without devs involved. We could do Member Office too but I don't think it's necessary and maybe more a source of error.

Who should be able to restore users?

I'm not sure we need that. Deleting users is already relatively rare, restoring them would be even more rare. If it's rare enough we can keep it for devs to fix with shell commands.