Disallow forward slash in process name. Closes #496

Author: mnaberez

CHANGES.txt

@@ -37,6 +37,10 @@
 - Fixed a bug where ``supervisorctl fg`` would swallow most XML-RPC faults.
   ``fg`` now prints the fault and exits.
 
+- Parsing the config file will now fail with an error message if a process
+  or group name contains a forward slash character (``/``) since it would
+  break the URLs used by the web interface.
+
 3.3.1 (2016-08-02)
 ------------------
 

supervisor/datatypes.py

@@ -12,9 +12,9 @@
 
 def process_or_group_name(name):
     """Ensures that a process or group name is not created with
-       characters that break the eventlistener protocol"""
+       characters that break the eventlistener protocol or web UI URLs"""
     s = str(name).strip()
-    if ' ' in s or ':' in s:
+    if ' ' in s or ':' in s or '/' in s:
         raise ValueError("Invalid name: " + repr(name))
     return s
 

supervisor/tests/test_datatypes.py

@@ -19,14 +19,18 @@ def test_strips_surrounding_whitespace(self):
         name = " foo\t"
         self.assertEqual(self._callFUT(name), "foo")
 
-    def test_disallows_inner_spaces(self):
+    def test_disallows_inner_spaces_for_eventlister_protocol(self):
         name = "foo bar"
         self.assertRaises(ValueError, self._callFUT, name)
 
-    def test_disallows_colons(self):
+    def test_disallows_colons_for_eventlistener_protocol(self):
         name = "foo:bar"
         self.assertRaises(ValueError, self._callFUT, name)
 
+    def test_disallows_slashes_for_web_ui_urls(self):
+        name = "foo/bar"
+        self.assertRaises(ValueError, self._callFUT, name)
+
 class IntegerTests(unittest.TestCase):
     def _callFUT(self, arg):
         return datatypes.integer(arg)