-
Notifications
You must be signed in to change notification settings - Fork 29
Description
According to the SBOL 2.3 specification, section 12.3: "Compliant SBOL Objects", item 6:
If a compliant SBOL object has a version, then its identity property MUST contain a URI of the form “〈persistentIdentity〉/〈version〉”.
Right now, test files such as BBa_J23101.xml have a version, but don't have the "/〈version〉" on their identity:
...
<sbol:ComponentDefinition rdf:about="https://synbiohub.org/public/igem/BBa_J23101">
<ns0:mutableDescription>later</ns0:mutableDescription>
<ns0:ownedBy rdf:resource="https://synbiohub.org/user/myers"/>
<sbol:type rdf:resource="http://www.biopax.org/release/biopax-level3.owl#DnaRegion"/>
<sbol:version>1</sbol:version>
...If I create a file with pysbol2 with SBOL_COMPLIANT_URIS as True, the identity will have the "/〈version〉".
Similarly, exports from SynbioHub right now also include the version in the identity:
...
<sbol:ComponentDefinition rdf:about="https://synbiohub.org/public/igem/BBa_J23101/1">
<sbol:persistentIdentity rdf:resource="https://synbiohub.org/public/igem/BBa_J23101"/>
<sbol:displayId>BBa_J23101</sbol:displayId>
<sbol:version>1</sbol:version>
...I propose we change these test files to versions with the compliant format, adding their versions to the end of their Identities.
This is important because we are generating new test files for the new converter with pysbol2, and we need to be able to test the changes we make.