De[bug]ger: Don't show address alongside symbol names

[warmCabin]

Looking at this snippet from Rockman 2's NMI routine, it seems a little odd that the PPU register names get substituted in but my symbol names sit next to their addresses. That's why I think this might a bug.

Shoutouts to that lazy guy.

[ClusterM]

Yes, seems like a bug.

[bbbradsmith]

Default register names were a relatively recent addition, I think by Feos?

[vadosnaprimer]

Not really recent. 20d0e3d

[ClusterM]

Seems like we really need an option to hide/show addresses for symbol debugging.

[bbbradsmith]

Heh, wow that was a lot further back than I realized.

Yeah I'd agree it'd be a useful option. I'd keep it on, myself, because I like the addresses, but it's definitely come up now and again. (As an aside: maybe the debugger could use a menu bar or a settings window, instead of trying to fit all the options into the panel?)

It occurs to me that the reason I keep the default register names off is entirely that it hides the numerical address, which I hadn't realized was also an inconsistency with other debugger labels.

[vadosnaprimer]

Menu sounds like a great idea.

[warmCabin]

I have a bit of a PR open where I'm addressing this and some other things I wanted to add. I removed the functionality completely because I am lazy and I really really hate it :/ But if other people like it, let's add a menu option!

Maybe we could make the address show up as a tooltip when you mouse over a label.

This interim build already has a menu bar along the top.

[bbbradsmith]

For a menu bar, I'd suggest grouping it into things that can have one-word headings. I think there's 8 controls that are crowded in the bottom right that could really stand to be out of the way instead of taking up permanent space there. Something like:

Options

• Auto open on ROM load
• IDA Font
• Reset Window Size (new)

Symbols

• Reload
• Load .DEB file

• ---

• Symbolic Debug
• Show Symbol Addresses (new)
• Default Register Names

Colors

• (as new Syntax highlight menu)

Tools

• ROM Patcher

As for tooltips when mousing over a label... I think that's fine as long as it's not a substitute for the option to actually display the address in the debugging panel.

[warmCabin]

@bbbradsmith Your menu ideas are great! I'm slowly making them come to life over in my branch.