Skip to content

[CHANGE REQUEST] Western/Southern hemisphere #593

@bent-lorentzen

Description

@bent-lorentzen

API Version

1.5.0, 1.6.1, 2.0

Summary

TOMP does not allow coordinates in the western hemisphere or the southern hemisphere.

Expected Behavior

When booking a ride west of Greenwich the user shouldn't be barred

Current Behavior

All coordinates with a negative latitude or longitude fails data integrity validation

Possible Solution

Change in 1.5.0 and 1.6.1
properties:
lng:
type: number
example: 6.169639
format: float
minimum: 0
lat:
type: number
example: 52.253279
format: float
minimum: 0
to
properties:
lng:
type: number
example: 6.169639
format: float
minimum: -180
lat:
type: number
example: 52.253279
format: float
minimum: -90
In 2.0
basePoint:
type: array
minItems: 2
maxItems: 2
items:
type: number
format: float
minimum: 0.0
to
basePoint:
type: array
minItems: 2
maxItems: 2
items:
type: number
format: float
minimum: -180.0

Steps to Reproduce

Try to perform a booking with negative latitude or longitude

Context (Environment)

Trying to book a ride in London

Metadata

Metadata

Labels

WT1To be discussed at the next meeting

Type

No type

Projects

Status

In review

Relationships

None yet

Development

No branches or pull requests

Issue actions