[TASK] Avoid json encoding of ParameterType

Doctrine DBAL 4 transform the `ParameterType`
from class to a native enum, which is a non
baked enum which prevents serialization of
the enum, for example using `json_encode()`.

The `DatabaseAccessor` used for the function
test `withSnapshot()` feature encodes column
information of the snapshotted data as json,
badly breaking down with `Doctrine DBAL 4`.

`TYPO3\CMS\Core\Database\Connection` has been
modified to determine the parameter types for
`insert()`, `update()` and similar methods
based on the database structure if the types
are not passed.

This change modifes the column preparation
to avoid the enum type and instead save the
doctrine type name as string. This is only
done, if `ParameterType` is a real enum and
therefore only with `Doctrine DBAL 4`.

The adjustment on the `Connection` is added
to the `Doctrine DBAL 4 Upgrade` change and
is therefore a tight coupled bridge.

[1] https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-converted-enum-like-classes-to-enums
[2] https://review.typo3.org/c/Packages/TYPO3.CMS/+/76553

Releases: main

Author: sbuerk

Classes/Core/Functional/Framework/DataHandling/Snapshot/DatabaseAccessor.php

@@ -17,7 +17,10 @@
 
 namespace TYPO3\TestingFramework\Core\Functional\Framework\DataHandling\Snapshot;
 
+use Doctrine\DBAL\ParameterType;
 use Doctrine\DBAL\Schema\Table;
+use Doctrine\DBAL\Types\Type;
+use Doctrine\DBAL\Types\Types;
 use TYPO3\CMS\Core\Database\Connection;
 use TYPO3\CMS\Core\Database\Query\QueryBuilder as TYPO3QueryBuilder;
 use TYPO3\TestingFramework\Core\Testbase;
@@ -116,9 +119,19 @@ private function prepareColumns(array $columnNames, Table $table): array
     {
         $columnTypes = array_map(
             function (string $columnName) use ($table) {
-                return $table->getColumn($columnName)
-                    ->getType()
-                    ->getBindingType();
+                // Doctrine DBAL v4 converted the `*ParameterType` to an enum, and therefore returning this enum instead
+                // of the string value like before. As this is a non-baked enum, it cannot be serialized or json_encoded,
+                // and breaking the snapshot export badly. Due to the requirement to support Doctrine DBAL v3 and v4 it
+                // is necessary to detect the enum end return the doctrine type name instead. The `Connection->insert()`
+                // adjustment is adjusted to transform the provided types during import to the correct ParameterType
+                // again.
+                // @see https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-converted-enum-like-classes-to-enums
+                // @todo Simplify this after Doctine DBAL v3 support can be dropped.
+                $type = $table->getColumn($columnName)->getType();
+                $bindingType = $type->getBindingType();
+                return (enum_exists(ParameterType::class))
+                    ? Type::lookupName($type)
+                    : $type->getBindingType();
             },
             $columnNames
         );