[Mike] 69. Storage key collision audit

[mikewheeleer]

Implement Storage key collision audit

Description

Audit and document all storage keys; add tests preventing collisions.

Requirements and context

• Must be secure, tested, and documented
• Should be efficient and easy to review
• Repository scope: Talenttrust/Talenttrust-Contracts only
• Keep implementation aligned with existing project architecture and coding standards

Suggested execution

• Fork the repo and create a branch
• git checkout -b feature/contracts-69-storage-key-collision-audit
• Implement changes
  • Write code in: contracts/escrow/src/lib.rs and related modules as needed
  • Write comprehensive tests: contracts/escrow/src/test.rs plus new focused test modules
  • Add documentation: README.md and docs/escrow/ as appropriate for this change
  • Include NatSpec-style comments where applicable (or equivalent structured doc comments)
  • Validate security assumptions and threat scenarios

Test and commit

• Run tests (cargo test)
• Cover edge cases and failure paths
• Include test output and security notes in the pull request description

Example commit message

feat: implement storage key collision audit with tests and docs

Guidelines

• Target minimum 95% test coverage for impacted modules
• Clear documentation with reviewer-focused structure
• Timeframe: 96 hours

[chiemezie1]

@chiemezie1 has applied to work on this issue as part of the Stellar Wave Program's 3rd wave.

Hey! I'd like to pick up issue #167 — the storage key collision audit.

I'll enumerate all storage keys across contracts/escrow/src/lib.rs and related modules, analyze collision risks from unnamespaced or input-derived keys, refactor to a typed DataKey enum where needed, and add tests asserting distinct XDR encoding per variant and no aliasing across user-supplied IDs. Docs go in docs/escrow/storage-key-registry.md with a full key table, plus README.md and inline /// comments. PR will include cargo test output and a security notes section covering key squatting and upgrade-path risks.

Can you assign this to me?

ℹ️ Repo Maintainers: To accept this application, review their application or assign @chiemezie1 to this issue.