Sync the `pre-commit` checks with what CI is doing.

[loverdos]

The idea is to have one source of truth for some checks, and make sure they all run and in the same way.

Example: CI was happy to merge #256 but apparently:

$ ./.pre-commit/pre-commit
[...]
==
== Results: 8 success(es), 1 failure(s)
== ✅ .pre-commit/01-cargo-check
== ✅ .pre-commit/02-cargo-clippy
== ✅ .pre-commit/03-cargo-nightly-fmt
== ✅ .pre-commit/04-cargo-nextest-build
== ✅ .pre-commit/05-cargo-nextest-run
== ❌ .pre-commit/06-md-lint
== ✅ .pre-commit/07-check-shebang
== ✅ .pre-commit/08-check-just-shebang
== ✅ .pre-commit/09-typos
==

See also the Slack thread.

Also related context: #235 (comment)

[zanicar]

This task is not assigned to anyone... It looks like an integration flow between local dev env and CI. Thus, is this an update required in the CI or on the dev env side (ensuring to run the same lint params locally before publishing code)?

[loverdos]

This task is not assigned to anyone... It looks like an integration flow between local dev env and CI. Thus, is this an update required in the CI or on the dev env side (ensuring to run the same lint params locally before publishing code)?

An update on the CI side. Now that we have all the pre-commit checks in place, my idea was to re-use them as they are. This way there is one source of truth for the checks, and I do not like GH actions holding the source of truth because GH actions cannot be run locally (yeah I know there are tools to do this but the situation is a joke).

I can take this (I own the parent ticket anyway).

[loverdos]

When the cache works (#267), timings look like this:

==
== Results: 12 success(es), 0 failure(s)
==      In: 03:42 [min:sec]
== 
== ✅ [00:14] .pre-commit/01-cargo-check
== ✅ [00:41] .pre-commit/02-cargo-clippy
== ✅ [00:01] .pre-commit/03-cargo-nightly-fmt
== ✅ [00:03] .pre-commit/04-check-container-runtime
== ✅ [00:57] .pre-commit/05-cargo-nextest-build
== ✅ [01:22] .pre-commit/06-cargo-nextest-run
== ✅ [00:01] .pre-commit/07-md-lint
== ✅ [00:00] .pre-commit/08-check-shebang
== ✅ [00:00] .pre-commit/09-check-just-shebang
== ✅ [00:00] .pre-commit/10-typos
== ✅ [00:22] .pre-commit/11-test-cli-completions
== ✅ [00:01] .pre-commit/12-executable-scripts
==

03:42 is much better than current (pre-this-PR) timings, which are around 13+ minutes.
Check 11 does a full build of the cli so it is indicative of how much it takes for a full build of anything with caching enabled.

It is interesting to note that with what we have in main currently, caching does not work. Perhaps the interaction with CARGO_INCREMENTAL creates problems.
Speaking of CARGO_INCREMENTAL, it seems that the global env does not propagate to the underlying jobs, so I have to explicitly set CARGO_INCREMENTAL=1 in the job step itself !!!