[UST-01C] Non-Uniform Storage Pattern

[dkuppitz]

UST-01C: Non-Uniform Storage Pattern

Type	Severity	Location
Code Style		USTB.sol:L29, L31

Description:

The overall codebase implements a pointer-based upgradeability-compatible storage pattern that is not applied in the USTB contract.

Example:

contract USTB is IUSTB, LayerZeroRebaseTokenUpgradeable, UUPSUpgradeable {
    using SafeERC20 for IERC20;

    address public constant UNDERLYING = 0x59D9356E565Ab3A36dD77763Fc0d87fEaf85508C;

    address public rebaseIndexManager;

    bool private _isMainChain;

Recommendation:

As is the case with all its dependencies, we advise the USTB contract to apply a similar pointer-based storage system.

[dkuppitz]

Thank you for the insight provided in audit item UST-01C, concerning the storage pattern in our USTB contract.

Upon review, we acknowledge the discrepancy between the storage patterns used in the USTB contract and the base contracts from which it inherits. Your recommendation to unify the storage approach by implementing a pointer-based storage system across all contracts, including USTB, is well-received.

While our initial design was to leverage the simplicity of direct storage for ease of understanding and interaction in the final contract, we recognize the importance of maintaining consistency throughout the codebase. Such uniformity not only fosters better maintainability but also ensures that our contracts adhere to a standard pattern that could facilitate future upgrades and integrations.

To this end, we have decided to adopt the pointer-based storage pattern in the USTB contract.

[dkuppitz]

Resolved in 083edf0.