Crash [TRNetworkManager directGetOffers:success:failure:]

[susslik]

Hi TapResearch team!
That's the re-opening of this issue - we've released the app with TapResearch 2.5.5 - but unfortunately, the crash still exists.
Currently that's the most common crash on our app - more than 50% of all the crashes. Crashlytics report for the last 7 days):

Please, find the stack traces below:

1. Crashed: Thread 1; EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x00000003b23f4380

0  libobjc.A.dylib                0x2c60 objc_retain_x0 + 16
1  libobjc.A.dylib                0x2c60 objc_retain + 16
2  TapResearchSDK                 0x9378 -[TRNetworkManager getOffers:success:failure:] + 400
3  TapResearchSDK                 0x16044 -[TRPlacementPollingThread getOffers] + 164
4  TapResearchSDK                 0x15ec0 -[TRPlacementPollingThread main] + 32
5  Foundation                     0x55f44 __NSThread__start__ + 704
6  libsystem_pthread.dylib        0x3060 _pthread_start + 116
7  libsystem_pthread.dylib        0x1688 thread_start + 8

2. Crashed: Thread 1; EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x0000000eb5667df0

0  libobjc.A.dylib                0x1c14 objc_msgSend + 20
1  TapResearchSDK                 0x9398 -[TRNetworkManager getOffers:success:failure:] + 432
2  TapResearchSDK                 0x16044 -[TRPlacementPollingThread getOffers] + 164
3  TapResearchSDK                 0x15ec0 -[TRPlacementPollingThread main] + 32
4  Foundation                     0x55f44 __NSThread__start__ + 704
5  libsystem_pthread.dylib        0x3060 _pthread_start + 116
6  libsystem_pthread.dylib        0x1688 thread_start + 8

3)Crashed: Thread 1; EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x0000000000000020

0  libobjc.A.dylib                0x3180 objc_release + 16
1  TapResearchSDK                 0x9584 -[TRNetworkManager getOffers:success:failure:] + 924
2  TapResearchSDK                 0x16044 -[TRPlacementPollingThread getOffers] + 164
3  TapResearchSDK                 0x15ec0 -[TRPlacementPollingThread main] + 32
4  Foundation                     0x6941c __NSThread__start__ + 808
5  libsystem_pthread.dylib        0x19ac _pthread_start + 148
6  libsystem_pthread.dylib        0xe68 thread_start + 8

4. Crashed: Thread 1; EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x00000008e38ebaa0

0  libobjc.A.dylib                0x3518 objc_release + 16
1  libobjc.A.dylib                0x3518 objc_release_x0 + 16
2  TapResearchSDK                 0x957c -[TRNetworkManager getOffers:success:failure:] + 916
3  TapResearchSDK                 0x16044 -[TRPlacementPollingThread getOffers] + 164
4  TapResearchSDK                 0x15ec0 -[TRPlacementPollingThread main] + 32
5  Foundation                     0x5ace8 __NSThread__start__ + 716
6  libsystem_pthread.dylib        0x16cc _pthread_start + 148
7  libsystem_pthread.dylib        0xba4 thread_start + 8

5. Crashed: Thread 1; EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x0000000b0fbecb80

0  libobjc.A.dylib                0x5290 objc_retainAutoreleaseReturnValue + 184
1  TapResearchSDK                 0x930c -[TRNetworkManager getOffers:success:failure:] + 292
2  TapResearchSDK                 0x16044 -[TRPlacementPollingThread getOffers] + 164
3  TapResearchSDK                 0x15ec0 -[TRPlacementPollingThread main] + 32
4  Foundation                     0x5b808 __NSThread__start__ + 716
5  libsystem_pthread.dylib        0x16cc _pthread_start + 148
6  libsystem_pthread.dylib        0xba4 thread_start + 8

[itsmikeq]

Thanks for the report @susslik! - We're taking a look at the crash and addressing it in an upcoming version.

[itsmikeq]

Hi @susslik - Can you please let me know if this is fixed in 2.5.6? We wrapped the area where we think the error existed. Instead of crashing, we should just shut down the webview.

[susslik]

Hi @PsyMike - thanks for the update! We will release the new app version with 2.5.6 shortly (this or next week), will let you know if the crash fixed.

[susslik]

Hi @PsyMike - sorry for the late reply. The app version with TapResearch 2.5.6 was released and about 90% of the users already using it. Unfortunately, we still see some of those crashes at the new app version with the updated SDK.
But should admit - it's 30-50% less compared to the previous version, so looks like we're moving in the right direction!
Please, find the latest stack traces we have at Crashlytics:

1. Crashed: Thread 1; EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x0000000983675940

0  libobjc.A.dylib                0x2e5c objc_retain_x0 + 16
1  libobjc.A.dylib                0x2e5c objc_retain + 16
2  TapResearchSDK                 0x918c -[TRNetworkManager getOffers:success:failure:] + 404
3  TapResearchSDK                 0x15f88 -[TRPlacementPollingThread getOffers] + 164
4  TapResearchSDK                 0x15e04 -[TRPlacementPollingThread main] + 32
5  Foundation                     0x5b808 __NSThread__start__ + 716
6  libsystem_pthread.dylib        0x16cc _pthread_start + 148
7  libsystem_pthread.dylib        0xba4 thread_start + 8

2. Crashed: Thread 1; EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x0000000f7a7aa960

0  libobjc.A.dylib                0x2e20 objc_retain + 16
1  libobjc.A.dylib                0x2e20 objc_retain_x0 + 16
2  TapResearchSDK                 0x911c -[TRNetworkManager getOffers:success:failure:] + 292
3  TapResearchSDK                 0x15f88 -[TRPlacementPollingThread getOffers] + 164
4  TapResearchSDK                 0x15e04 -[TRPlacementPollingThread main] + 32
5  Foundation                     0x5ace8 __NSThread__start__ + 716
6  libsystem_pthread.dylib        0x16cc _pthread_start + 148
7  libsystem_pthread.dylib        0xba4 thread_start + 8

3. Crashed: Thread 1; EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x000023f32425e5f0

0  libobjc.A.dylib                0x1c20 objc_msgSend + 32
1  TapResearchSDK                 0x913c -[TRNetworkManager getOffers:success:failure:] + 324
2  TapResearchSDK                 0x15f88 -[TRPlacementPollingThread getOffers] + 164
3  TapResearchSDK                 0x15e04 -[TRPlacementPollingThread main] + 32
4  Foundation                     0x5b808 __NSThread__start__ + 716
5  libsystem_pthread.dylib        0x16cc _pthread_start + 148
6  libsystem_pthread.dylib        0xba4 thread_start + 8

4. Crashed: Thread 1; EXC_BAD_ACCESS KERN_PROTECTION_FAILURE 0x0000000fddd6fda0

0  libobjc.A.dylib                0x2e5c objc_retain_x0 + 16
1  libobjc.A.dylib                0x2e5c objc_retain + 16
2  TapResearchSDK                 0x918c -[TRNetworkManager getOffers:success:failure:] + 404
3  TapResearchSDK                 0x15f88 -[TRPlacementPollingThread getOffers] + 164
4  TapResearchSDK                 0x15e04 -[TRPlacementPollingThread main] + 32
5  Foundation                     0x5b808 __NSThread__start__ + 716
6  libsystem_pthread.dylib        0x16cc _pthread_start + 148
7  libsystem_pthread.dylib        0xba4 thread_start + 8

5. Crashed: Thread 1; EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x00000009a77e5ae0

0  libobjc.A.dylib                0x3150 objc_retain + 16
1  TapResearchSDK                 0x9124 -[TRNetworkManager getOffers:success:failure:] + 300
2  TapResearchSDK                 0x15f88 -[TRPlacementPollingThread getOffers] + 164
3  TapResearchSDK                 0x15e04 -[TRPlacementPollingThread main] + 32
4  Foundation                     0x64d2c __NSThread__start__ + 792
5  libsystem_pthread.dylib        0x3348 _pthread_start + 116
6  libsystem_pthread.dylib        0x1948 thread_start + 8

I also see those crashes at Xcode organizer, the stack traces are similar except thread's number (it's always 1 at Crashlytics, but 16-19-21-etc at Xcode organizer).

Could you take a look, please?
Please, let me know if I can help somehow!

[susslik]

Hi TapResearch team!
Recently we released the new app version with TapResearch 2.5.8, unfortunately, the crashes are not fully resolved yet.
Please, find the latest stack traces we have at Crashlytics:

1. Crashed: Thread 1; EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x00002b331bf353f0

0  libobjc.A.dylib                0x1c20 objc_msgSend + 32
1  TapResearchSDK                 0x8c3c -[TRNetworkManager getOffers:success:failure:] + 377 (TRNetworkManager.m:377)
2  TapResearchSDK                 0x15d48 -[TRPlacementPollingThread getOffers] + 105 (TRPlacementPollingThread.m:105)
3  TapResearchSDK                 0x15b34 -[TRPlacementPollingThread main] + 71 (TRPlacementPollingThread.m:71)
4  Foundation                     0x5b518 __NSThread__start__ + 716
5  libsystem_pthread.dylib        0x16cc _pthread_start + 148
6  libsystem_pthread.dylib        0xba4 thread_start + 8

2. Crashed: Thread 1; EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x00000002a0080020

0  libobjc.A.dylib                0x3554 objc_release_x0 + 16
1  libobjc.A.dylib                0x3554 objc_release + 16
2  TapResearchSDK                 0x8e30 -[TRNetworkManager getOffers:success:failure:] + 410 (TRNetworkManager.m:410)
3  TapResearchSDK                 0x15d48 -[TRPlacementPollingThread getOffers] + 105 (TRPlacementPollingThread.m:105)
4  TapResearchSDK                 0x15b34 -[TRPlacementPollingThread main] + 71 (TRPlacementPollingThread.m:71)
5  Foundation                     0x5b808 __NSThread__start__ + 716
6  libsystem_pthread.dylib        0x16cc _pthread_start + 148
7  libsystem_pthread.dylib        0xba4 thread_start + 8```