In JavaScriptEngineSwitcher.V8 removed unnecessary locks from the V8JsEngine class

Author: Taritsyn

src/JavaScriptEngineSwitcher.V8/V8JsEngine.cs

@@ -46,11 +46,6 @@ public sealed class V8JsEngine : JsEngineBase
 			new Regex(@"[ ]{3,5}at (?:[A-Za-z_\$][0-9A-Za-z_\$]* )?" +
 				@"\(?[^\s*?""<>|][^\t\n\r*?""<>|]*?:(?<lineNumber>\d+):(?<columnNumber>\d+)\)? -> ");
 
-		/// <summary>
-		/// Synchronizer of code execution
-		/// </summary>
-		private readonly object _executionSynchronizer = new object();
-
 		/// <summary>
 		/// Gets a name of JS engine
 		/// </summary>
@@ -224,16 +219,13 @@ protected override object InnerEvaluate(string expression, string documentName)
 		{
 			object result;
 
-			lock (_executionSynchronizer)
+			try
 			{
-				try
-				{
-					result = _jsEngine.Evaluate(documentName, false, expression);
-				}
-				catch (OriginalJsException e)
-				{
-					throw ConvertScriptEngineExceptionToJsRuntimeException(e);
-				}
+				result = _jsEngine.Evaluate(documentName, false, expression);
+			}
+			catch (OriginalJsException e)
+			{
+				throw ConvertScriptEngineExceptionToJsRuntimeException(e);
 			}
 
 			result = MapToHostType(result);
@@ -260,16 +252,13 @@ protected override void InnerExecute(string code)
 
 		protected override void InnerExecute(string code, string documentName)
 		{
-			lock (_executionSynchronizer)
+			try
 			{
-				try
-				{
-					_jsEngine.Execute(documentName, false, code);
-				}
-				catch (OriginalJsException e)
-				{
-					throw ConvertScriptEngineExceptionToJsRuntimeException(e);
-				}
+				_jsEngine.Execute(documentName, false, code);
+			}
+			catch (OriginalJsException e)
+			{
+				throw ConvertScriptEngineExceptionToJsRuntimeException(e);
 			}
 		}
 
@@ -287,16 +276,13 @@ protected override object InnerCallFunction(string functionName, params object[]
 				}
 			}
 
-			lock (_executionSynchronizer)
+			try
 			{
-				try
-				{
-					result = _jsEngine.Invoke(functionName, processedArgs);
-				}
-				catch (OriginalJsException e)
-				{
-					throw ConvertScriptEngineExceptionToJsRuntimeException(e);
-				}
+				result = _jsEngine.Invoke(functionName, processedArgs);
+			}
+			catch (OriginalJsException e)
+			{
+				throw ConvertScriptEngineExceptionToJsRuntimeException(e);
 			}
 
 			result = MapToHostType(result);
@@ -323,16 +309,13 @@ protected override object InnerGetVariableValue(string variableName)
 		{
 			object result;
 
-			lock (_executionSynchronizer)
+			try
 			{
-				try
-				{
-					result = _jsEngine.Script[variableName];
-				}
-				catch (OriginalJsException e)
-				{
-					throw ConvertScriptEngineExceptionToJsRuntimeException(e);
-				}
+				result = _jsEngine.Script[variableName];
+			}
+			catch (OriginalJsException e)
+			{
+				throw ConvertScriptEngineExceptionToJsRuntimeException(e);
 			}
 
 			result = MapToHostType(result);
@@ -351,16 +334,13 @@ protected override void InnerSetVariableValue(string variableName, object value)
 		{
 			object processedValue = MapToClearScriptType(value);
 
-			lock (_executionSynchronizer)
+			try
 			{
-				try
-				{
-					_jsEngine.Script[variableName] = processedValue;
-				}
-				catch (OriginalJsException e)
-				{
-					throw ConvertScriptEngineExceptionToJsRuntimeException(e);
-				}
+				_jsEngine.Script[variableName] = processedValue;
+			}
+			catch (OriginalJsException e)
+			{
+				throw ConvertScriptEngineExceptionToJsRuntimeException(e);
 			}
 		}
 
@@ -373,40 +353,31 @@ protected override void InnerEmbedHostObject(string itemName, object value)
 		{
 			object processedValue = MapToClearScriptType(value);
 
-			lock (_executionSynchronizer)
+			try
 			{
-				try
-				{
-					_jsEngine.AddHostObject(itemName, processedValue);
-				}
-				catch (OriginalJsException e)
-				{
-					throw ConvertScriptEngineExceptionToJsRuntimeException(e);
-				}
+				_jsEngine.AddHostObject(itemName, processedValue);
+			}
+			catch (OriginalJsException e)
+			{
+				throw ConvertScriptEngineExceptionToJsRuntimeException(e);
 			}
 		}
 
 		protected override void InnerEmbedHostType(string itemName, Type type)
 		{
-			lock (_executionSynchronizer)
+			try
 			{
-				try
-				{
-					_jsEngine.AddHostType(itemName, type);
-				}
-				catch (OriginalJsException e)
-				{
-					throw ConvertScriptEngineExceptionToJsRuntimeException(e);
-				}
+				_jsEngine.AddHostType(itemName, type);
+			}
+			catch (OriginalJsException e)
+			{
+				throw ConvertScriptEngineExceptionToJsRuntimeException(e);
 			}
 		}
 
 		protected override void InnerCollectGarbage()
 		{
-			lock (_executionSynchronizer)
-			{
-				_jsEngine.CollectGarbage(true);
-			}
+			_jsEngine.CollectGarbage(true);
 		}
 
 		#endregion