In JavaScriptEngineSwitcher.ChakraCore in configuration settings of the ChakraCore JS engine was added one new property - MaxStackSize

Author: Taritsyn

src/JavaScriptEngineSwitcher.ChakraCore/ChakraCoreJsEngine.cs

@@ -93,7 +93,7 @@ public sealed class ChakraCoreJsEngine : JsEngineBase
 		/// <summary>
 		/// Script dispatcher
 		/// </summary>
-		private readonly ScriptDispatcher _dispatcher = new ScriptDispatcher();
+		private readonly ScriptDispatcher _dispatcher;
 
 		/// <summary>
 		/// Unique document name manager
@@ -155,6 +155,7 @@ public ChakraCoreJsEngine(ChakraCoreSettings settings)
 				attributes |= JsRuntimeAttributes.EnableExperimentalFeatures;
 			}
 
+			_dispatcher = new ScriptDispatcher(chakraCoreSettings.MaxStackSize);
 			_externalObjectFinalizeCallback = ExternalObjectFinalizeCallback;
 			_promiseContinuationCallback = PromiseContinuationCallback;
 

src/JavaScriptEngineSwitcher.ChakraCore/ChakraCoreSettings.cs

@@ -2,13 +2,30 @@
 
 using JavaScriptEngineSwitcher.Core.Utilities;
 
+using JavaScriptEngineSwitcher.ChakraCore.Resources;
+
 namespace JavaScriptEngineSwitcher.ChakraCore
 {
 	/// <summary>
 	/// Settings of the ChakraCore JS engine
 	/// </summary>
 	public sealed class ChakraCoreSettings
 	{
+		/// <summary>
+		/// The stack size is sufficient to run the code of modern JavaScript libraries in 32-bit process
+		/// </summary>
+		const int STACK_SIZE_32 = 492 * 1024; // like 32-bit Node.js
+
+		/// <summary>
+		/// The stack size is sufficient to run the code of modern JavaScript libraries in 64-bit process
+		/// </summary>
+		const int STACK_SIZE_64 = 984 * 1024; // like 64-bit Node.js
+
+		/// <summary>
+		/// The maximum stack size in bytes
+		/// </summary>
+		private int _maxStackSize;
+
 		/// <summary>
 		/// Gets or sets a flag for whether to disable any background work (such as garbage collection)
 		/// on background threads
@@ -55,6 +72,31 @@ public bool EnableExperimentalFeatures
 			set;
 		}
 
+		/// <summary>
+		/// Gets or sets a maximum stack size in bytes
+		/// </summary>
+		/// <remarks>
+		/// <para>Set a <code>0</code> to use the default maximum stack size specified in the header
+		/// for the executable.
+		/// </para>
+		/// </remarks>
+		public int MaxStackSize
+		{
+			get { return _maxStackSize; }
+			set
+			{
+				if (value < 0)
+				{
+					throw new ArgumentOutOfRangeException(
+						nameof(value),
+						Strings.Engine_MaxStackSizeMustBeNonNegative
+					);
+				}
+
+				_maxStackSize = value;
+			}
+		}
+
 		/// <summary>
 		/// Gets or sets a current memory limit for a runtime in bytes
 		/// </summary>
@@ -70,13 +112,15 @@ public UIntPtr MemoryLimit
 		/// </summary>
 		public ChakraCoreSettings()
 		{
+			bool is64BitProcess = Utils.Is64BitProcess();
+
 			DisableBackgroundWork = false;
 			DisableEval = false;
 			DisableFatalOnOOM = false;
 			DisableNativeCodeGeneration = false;
 			EnableExperimentalFeatures = false;
-			MemoryLimit = Utils.Is64BitProcess() ?
-				new UIntPtr(ulong.MaxValue) : new UIntPtr(uint.MaxValue);
+			MaxStackSize = is64BitProcess ? STACK_SIZE_64 : STACK_SIZE_32;
+			MemoryLimit = is64BitProcess ? new UIntPtr(ulong.MaxValue) : new UIntPtr(uint.MaxValue);
 		}
 	}
 }

src/JavaScriptEngineSwitcher.ChakraCore/JavaScriptEngineSwitcher.ChakraCore.csproj

@@ -22,9 +22,7 @@ This package does not contain the native implementations of ChakraCore. Therefor
  * JavaScriptEngineSwitcher.ChakraCore.Native.osx-x64</Description>
 		<PackageIconUrl>https://raw.githubusercontent.com/Taritsyn/JavaScriptEngineSwitcher/master/Icons/JavaScriptEngineSwitcher_ChakraCore_Logo128x128.png</PackageIconUrl>
 		<PackageTags>JavaScriptEngineSwitcher;JavaScript;ECMAScript;ChakraCore</PackageTags>
-		<PackageReleaseNotes>1. ChakraCore was updated to version 1.7.5;
-2. In configuration settings of the ChakraCore JS engine was added two new properties - `MemoryLimit` and `DisableFatalOnOOM` (default `false`);
-3. Now during calling of the `CollectGarbage` method is no longer performed blocking.</PackageReleaseNotes>
+		<PackageReleaseNotes>In configuration settings of the ChakraCore JS engine was added one new property - `MaxStackSize` (default `492` or `984` KB).</PackageReleaseNotes>
 	</PropertyGroup>
 
 	<Import Project="../../build/common.props" />

src/JavaScriptEngineSwitcher.ChakraCore/Resources/Strings.Designer.cs

@@ -183,4 +183,7 @@
   <data name="Engine_VcRedist2015InstallationRequired" xml:space="preserve">
     <value>In addition, you still need to install the Microsoft Visual C++ 2015 Redistributable (https://www.microsoft.com/en-us/download/details.aspx?id=53840).</value>
   </data>
+  <data name="Engine_MaxStackSizeMustBeNonNegative" xml:space="preserve">
+    <value>Maximum stack size must be non-negative.</value>
+  </data>
 </root>

src/JavaScriptEngineSwitcher.ChakraCore/Resources/Strings.resx

@@ -183,4 +183,7 @@
   <data name="Engine_VcRedist2015InstallationRequired" xml:space="preserve">
     <value>Кроме того, еще требуется установка распространяемого компонента Microsoft Visual C++ 2015 (https://www.microsoft.com/ru-ru/download/details.aspx?id=53840).</value>
   </data>
+  <data name="Engine_MaxStackSizeMustBeNonNegative" xml:space="preserve">
+    <value>Максимальный размер стека должен быть неотрицательным!</value>
+  </data>
 </root>

src/JavaScriptEngineSwitcher.ChakraCore/Resources/Strings.ru-ru.resx

@@ -14,24 +14,12 @@
 namespace JavaScriptEngineSwitcher.ChakraCore
 {
 	/// <summary>
-	/// Provides services for managing the queue of script tasks on the thread with increased stack size
+	/// Provides services for managing the queue of script tasks on the thread with modified stack size
 	/// </summary>
 	internal sealed class ScriptDispatcher : IDisposable
 	{
-#if !NETSTANDARD1_3
 		/// <summary>
-		/// The stack size is sufficient to run the code of modern JavaScript libraries in 32-bit process
-		/// </summary>
-		const int STACK_SIZE_32 = 492 * 1024; // like 32-bit Node.js
-
-		/// <summary>
-		/// The stack size is sufficient to run the code of modern JavaScript libraries in 64-bit process
-		/// </summary>
-		const int STACK_SIZE_64 = 984 * 1024; // like 64-bit Node.js
-
-#endif
-		/// <summary>
-		/// The thread with increased stack size
+		/// The thread with modified stack size
 		/// </summary>
 		private Thread _thread;
 
@@ -59,14 +47,14 @@ internal sealed class ScriptDispatcher : IDisposable
 		/// <summary>
 		/// Constructs an instance of script dispatcher
 		/// </summary>
-		public ScriptDispatcher()
+		/// <param name="maxStackSize">The maximum stack size, in bytes, to be used by the thread,
+		/// or 0 to use the default maximum stack size specified in the header for the executable.</param>
+		public ScriptDispatcher(int maxStackSize)
 		{
 #if NETSTANDARD1_3
 			_thread = new Thread(StartThread)
 #else
-			int sufficientStackSize = Utils.Is64BitProcess() ? STACK_SIZE_64 : STACK_SIZE_32;
-
-			_thread = new Thread(StartThread, sufficientStackSize)
+			_thread = new Thread(StartThread, maxStackSize)
 #endif
 			{
 				IsBackground = true
@@ -85,7 +73,7 @@ private void VerifyNotDisposed()
 		}
 
 		/// <summary>
-		/// Starts a thread with increased stack size.
+		/// Starts a thread with modified stack size.
 		/// Loops forever, processing script tasks from the queue.
 		/// </summary>
 		private void StartThread()
@@ -141,7 +129,7 @@ private void EnqueueTask(ScriptTask task)
 		}
 
 		/// <summary>
-		/// Runs a specified delegate on the thread with increased stack size,
+		/// Runs a specified delegate on the thread with modified stack size,
 		/// and returns its result as an <see cref="System.Object"/>.
 		/// Blocks until the invocation of delegate is completed.
 		/// </summary>
@@ -176,7 +164,7 @@ private object InnnerInvoke(Func<object> del)
 		}
 
 		/// <summary>
-		/// Runs a specified delegate on the thread with increased stack size,
+		/// Runs a specified delegate on the thread with modified stack size,
 		/// and returns its result as an <typeparamref name="T" />.
 		/// Blocks until the invocation of delegate is completed.
 		/// </summary>
@@ -197,7 +185,7 @@ public T Invoke<T>(Func<T> func)
 		}
 
 		/// <summary>
-		/// Runs a specified delegate on the thread with increased stack size.
+		/// Runs a specified delegate on the thread with modified stack size.
 		/// Blocks until the invocation of delegate is completed.
 		/// </summary>
 		/// <param name="action">Delegate to invocation</param>

src/JavaScriptEngineSwitcher.ChakraCore/ScriptDispatcher.cs

@@ -30,11 +30,8 @@
    =============
    RELEASE NOTES
    =============
-   1. ChakraCore was updated to version 1.7.5;
-   2. In configuration settings of the ChakraCore JS engine was added two new
-      properties - `MemoryLimit` and `DisableFatalOnOOM` (default `false`);
-   3. Now during calling of the `CollectGarbage` method is no longer performed
-      blocking.
+   In configuration settings of the ChakraCore JS engine was added one new
+   property - `MaxStackSize` (default `492` or `984` KB).
 
    =============
    DOCUMENTATION