In JavaScriptEngineSwitcher.V8 implemented a handling of error “Internal error. Icu error”

Author: Taritsyn

src/JavaScriptEngineSwitcher.V8/JavaScriptEngineSwitcher.V8.csproj

@@ -30,7 +30,7 @@ This package does not contain the native ClearScript.V8 assemblies. Therefore, y
  * Microsoft.ClearScript.V8.Native.osx-arm64</Description>
     <PackageTags>$(PackageCommonTags);V8;ClearScript</PackageTags>
     <PackageIconFullPath>../../Icons/JavaScriptEngineSwitcher_V8_Logo128x128.png</PackageIconFullPath>
-    <PackageReleaseNotes>Microsoft ClearScript.V8 was updated to version 7.1.6.</PackageReleaseNotes>
+    <PackageReleaseNotes>Implemented a handling of error “Internal error. Icu error”.</PackageReleaseNotes>
   </PropertyGroup>
 
   <ItemGroup>

src/JavaScriptEngineSwitcher.V8/Resources/Strings.Designer.cs

@@ -117,6 +117,9 @@
   <resheader name="writer">
     <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
+  <data name="Engine_InternationalizationApiNotFullySupported" xml:space="preserve">
+    <value>By default, some features of the JavaScript Internationalization API are not supported.</value>
+  </data>
   <data name="Usage_PrecompiledScriptNotAccepted" xml:space="preserve">
     <value>Pre-compiled script is not accepted. To be accepted, the pre-compiled script must have been created by the same V8 build.</value>
   </data>

src/JavaScriptEngineSwitcher.V8/Resources/Strings.resx

@@ -117,6 +117,9 @@
   <resheader name="writer">
     <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
+  <data name="Engine_InternationalizationApiNotFullySupported" xml:space="preserve">
+    <value>По умолчанию некоторые возможности JavaScript Internationalization API не поддерживаются.</value>
+  </data>
   <data name="Usage_PrecompiledScriptNotAccepted" xml:space="preserve">
     <value>Предварительно скомпилированный сценарий не принят! Чтобы быть принятым, предварительно скомпилированный сценарий должен быть создан той же сборкой V8.</value>
   </data>

src/JavaScriptEngineSwitcher.V8/Resources/Strings.ru-ru.resx

@@ -247,6 +247,19 @@ private static WrapperException WrapScriptEngineException(OriginalException orig
 					}
 					else
 					{
+						if (description == "Internal error. Icu error.")
+						{
+							var stringBuilderPool = StringBuilderPool.Shared;
+							StringBuilder descriptionBuilder = stringBuilderPool.Rent();
+							descriptionBuilder.Append(Strings.Engine_InternationalizationApiNotFullySupported);
+							descriptionBuilder.Append(" ");
+							descriptionBuilder.AppendFormat(CoreStrings.Engine_NuGetPackageInstallationRequired,
+								"Microsoft.ClearScript.V8.ICUData");
+
+							description = descriptionBuilder.ToString();
+							stringBuilderPool.Return(descriptionBuilder);
+						}
+
 						callStack = JsErrorHelpers.StringifyErrorLocationItems(errorLocationItems, true);
 						string callStackWithSourceFragment = JsErrorHelpers.StringifyErrorLocationItems(
 							errorLocationItems);

src/JavaScriptEngineSwitcher.V8/V8JsEngine.cs

@@ -31,7 +31,7 @@
    =============
    RELEASE NOTES
    =============
-   Microsoft ClearScript.V8 was updated to version 7.1.6.
+   Implemented a handling of error “Internal error. Icu error”.
 
    =============
    DOCUMENTATION

src/JavaScriptEngineSwitcher.V8/readme.txt

@@ -182,6 +182,44 @@ public void MappingRuntimeErrorDuringExecutionOfCodeIsCorrect()
 			);
 		}
 
+		[Fact]
+		public void MappingRuntimeErrorDuringUsingInternationalizationApiIsCorrect()
+		{
+			// Arrange
+			const string functionCode = @"function formatDate(value, locale) {
+	if (typeof value === 'string' && value.length > 0) {
+		value = new Date(value);
+	}
+
+	return new Intl.DateTimeFormat(locale).format(value);
+}";
+
+			JsRuntimeException exception = null;
+
+			// Act
+			using (var jsEngine = CreateJsEngine())
+			{
+				try
+				{
+					jsEngine.Execute(functionCode);
+					string result = jsEngine.CallFunction<string>("formatDate", "2021-09-16", "ru-ru");
+				}
+				catch (JsRuntimeException e)
+				{
+					exception = e;
+				}
+			}
+
+			// Assert
+			Assert.NotNull(exception);
+			Assert.Equal("Runtime error", exception.Category);
+			Assert.Equal(
+				"By default, some features of the JavaScript Internationalization API are not supported. " +
+				"Try to install the Microsoft.ClearScript.V8.ICUData package via NuGet.",
+				exception.Description
+			);
+		}
+
 		[Fact]
 		public void MappingRuntimeErrorDuringOutOfMemoryIsCorrect()
 		{