In JavaScriptEngineSwitcher.ChakraCore fixed a error, that occurred during finding a suitable method overload, that receives interfaces as parameters, of the host object

Author: Taritsyn

NuGet/JavaScriptEngineSwitcher.ChakraCore/JavaScriptEngineSwitcher.ChakraCore.nuspec

@@ -20,7 +20,7 @@ This package does not contain the native implementations of ChakraCore. Therefor
  * JavaScriptEngineSwitcher.ChakraCore.Native.linux-x64
  * JavaScriptEngineSwitcher.ChakraCore.Native.osx-x64</description>
 		<summary>JavaScriptEngineSwitcher.ChakraCore contains adapter `ChakraCoreJsEngine` (wrapper for the ChakraCore).</summary>
-		<releaseNotes>Fixed a error, that occurred during finding a suitable method overload, that receives numeric parameters, of the host object.</releaseNotes>
+		<releaseNotes>Fixed a error, that occurred during finding the suitable method overload, that receives numeric values and interfaces as parameters, of the host object.</releaseNotes>
 		<copyright>Copyright (c) 2013-2017 Andrey Taritsyn - http://www.taritsyn.ru</copyright>
 		<language>en-US</language>
 		<tags>JavaScriptEngineSwitcher JavaScript ECMAScript ChakraCore</tags>

NuGet/JavaScriptEngineSwitcher.ChakraCore/readme.txt

@@ -30,8 +30,8 @@
    =============
    RELEASE NOTES
    =============
-   Fixed a error, that occurred during finding a suitable method overload, that
-   receives numeric parameters, of the host object.
+   Fixed a error, that occurred during finding the suitable method overload, that
+   receives numeric values and interfaces as parameters, of the host object.
 
    =============
    DOCUMENTATION

src/JavaScriptEngineSwitcher.ChakraCore/Helpers/ReflectionHelpers.cs

@@ -169,19 +169,16 @@ private static bool CompareParameterTypes(object[] argValues, Type[] argTypes, T
 				}
 				else
 				{
-					if (NumericHelpers.IsNumericType(argType) && NumericHelpers.IsNumericType(parameterType))
-					{
-						object convertedArgValue;
-
-						if (!TypeConverter.TryConvertToType(argValue, parameterType, out convertedArgValue))
-						{
-							return false;
-						}
+					// TODO: It is necessary to calculate the compatibility score based on length
+					// of inheritance and interface implementation chains.
+					object convertedArgValue;
 
-						continue;
+					if (!TypeConverter.TryConvertToType(argValue, parameterType, out convertedArgValue))
+					{
+						return false;
 					}
 
-					return false;
+					continue;
 				}
 			}
 
@@ -203,6 +200,7 @@ public Type[] ParameterTypes
 				set;
 			}
 
+			/// TODO: In future will need to change type to <code>double</code>
 			public ushort CompatibilityScore
 			{
 				get;

test/JavaScriptEngineSwitcher.Tests/Interop/Animals/AnimalTrainer.cs

@@ -0,0 +1,10 @@
+namespace JavaScriptEngineSwitcher.Tests.Interop.Animals
+{
+	public sealed class AnimalTrainer
+	{
+		public string ExecuteVoiceCommand(IAnimal animal)
+		{
+			return animal.Cry();
+		}
+	}
+}

test/JavaScriptEngineSwitcher.Tests/Interop/Animals/Cat.cs

@@ -0,0 +1,10 @@
+namespace JavaScriptEngineSwitcher.Tests.Interop.Animals
+{
+	public sealed class Cat : IAnimal
+	{
+		public string Cry()
+		{
+			return "Meow!";
+		}
+	}
+}

test/JavaScriptEngineSwitcher.Tests/Interop/Animals/Dog.cs

@@ -0,0 +1,10 @@
+namespace JavaScriptEngineSwitcher.Tests.Interop.Animals
+{
+	public sealed class Dog : IAnimal
+	{
+		public string Cry()
+		{
+			return "Woof!";
+		}
+	}
+}

test/JavaScriptEngineSwitcher.Tests/Interop/Animals/IAnimal.cs

@@ -0,0 +1,7 @@
+namespace JavaScriptEngineSwitcher.Tests.Interop.Animals
+{
+	public interface IAnimal
+	{
+		string Cry();
+	}
+}

test/JavaScriptEngineSwitcher.Tests/InteropTestsBase.cs

@@ -9,6 +9,7 @@
 using Xunit;
 
 using JavaScriptEngineSwitcher.Tests.Interop;
+using JavaScriptEngineSwitcher.Tests.Interop.Animals;
 #if NETCOREAPP1_0
 using JavaScriptEngineSwitcher.Tests.Interop.Drawing;
 #endif
@@ -353,6 +354,38 @@ public virtual void EmbeddingOfInstanceOfCustomReferenceTypeWithMethodIsCorrect(
 			Assert.Equal(targetOutput, output);
 		}
 
+		[Fact]
+		public virtual void CallingOfMethodOfCustomReferenceTypeWithInterfaceParameterIsCorrect()
+		{
+			// Arrange
+			var animalTrainer = new AnimalTrainer();
+			var cat = new Cat();
+			var dog = new Dog();
+
+			const string input1 = "animalTrainer.ExecuteVoiceCommand(cat)";
+			const string targetOutput1 = "Meow!";
+
+			const string input2 = "animalTrainer.ExecuteVoiceCommand(dog)";
+			const string targetOutput2 = "Woof!";
+
+			// Act
+			string output1;
+			string output2;
+
+			using (var jsEngine = CreateJsEngine())
+			{
+				jsEngine.EmbedHostObject("animalTrainer", animalTrainer);
+				jsEngine.EmbedHostObject("cat", cat);
+				jsEngine.EmbedHostObject("dog", dog);
+				output1 = jsEngine.Evaluate<string>(input1);
+				output2 = jsEngine.Evaluate<string>(input2);
+			}
+
+			// Assert
+			Assert.Equal(targetOutput1, output1);
+			Assert.Equal(targetOutput2, output2);
+		}
+
 		#endregion
 
 		#region Delegates