All exceptions made serializable

Author: Taritsyn

NuGet/MsieJavaScriptEngine.nuspec

@@ -12,8 +12,7 @@
 		<requireLicenseAcceptance>false</requireLicenseAcceptance>
 		<description>This library is a .NET wrapper for working with the JavaScript engines of Internet Explorer and Edge (JsRT versions of Chakra, ActiveScript version of Chakra and Classic JavaScript Engine). Project was based on the code of SassAndCoffee.JavaScript (http://github.com/paulcbetts/SassAndCoffee), Chakra Sample Hosts (http://github.com/panopticoncentral/chakra-host) and jsrt-dotnet (http://github.com/robpaveza/jsrt-dotnet).</description>
 		<summary>This library is a .NET wrapper for working with the JavaScript engines of Internet Explorer and Edge (JsRT versions of Chakra, ActiveScript version of Chakra and Classic JavaScript Engine).</summary>
-		<releaseNotes>1. Added support of .NET Core 1.0.1 (only supported `ChakraIeJsRt` and `ChakraEdgeJsRt` modes) and .NET Framework 4.5.1;
-2. Added the `CollectGarbage` method.</releaseNotes>
+		<releaseNotes>All exceptions made serializable.</releaseNotes>
 		<copyright>Copyright (c) 2012-2016 Andrey Taritsyn - http://www.taritsyn.ru</copyright>
 		<language>en-US</language>
 		<tags>JavaScript ECMAScript MSIE IE Edge Chakra</tags>

NuGet/readme.txt

@@ -21,9 +21,7 @@
    =============
    RELEASE NOTES
    =============
-   1. Added support of .NET Core 1.0.1 (only supported `ChakraIeJsRt` and
-      `ChakraEdgeJsRt` modes) and .NET Framework 4.5.1;
-   2. Added the `CollectGarbage` method.
+   All exceptions made serializable.
 
    ============
    PROJECT SITE

build.cmd

@@ -11,7 +11,7 @@ set local_nuget_package_manager=.nuget\NuGet.exe
 set package_dir=packages
 
 if not exist %package_dir%\NUnit.Runners (
-	%local_nuget_package_manager% install NUnit.Runners -Version 3.5.0 -O %package_dir% -ExcludeVersion -NoCache
+	%local_nuget_package_manager% install NUnit.Runners -Version 3.4.1 -O %package_dir% -ExcludeVersion -NoCache
 )
 
 PowerShell -NoProfile -NoLogo -ExecutionPolicy unrestricted -Command "[System.Threading.Thread]::CurrentThread.CurrentCulture = ''; [System.Threading.Thread]::CurrentThread.CurrentUICulture = '';& '%~dp0build.ps1' %*; exit $LASTEXITCODE"

build.sh

@@ -10,7 +10,7 @@ localNugetPackageManager=.nuget/NuGet.exe
 packageDir=packages
 
 if test ! -d $packageDir/NUnit.Runners; then
-  mono $localNugetPackageManager install NUnit.Runners -Version 3.5.0 -O $packageDir% -ExcludeVersion -NoCache
+  mono $localNugetPackageManager install NUnit.Runners -Version 3.4.1 -O $packageDir% -ExcludeVersion -NoCache
 fi
 
 koreBuildZip="https://github.com/aspnet/KoreBuild/archive/1.0.0.zip"

src/MsieJavaScriptEngine/ActiveScript/ActiveScriptException.cs

@@ -1,85 +1,116 @@
 #if !NETSTANDARD1_3
 using System;
-using System.Runtime.Serialization;
 using System.Runtime.InteropServices.ComTypes;
+using System.Runtime.Serialization;
+using System.Security.Permissions;
 
 namespace MsieJavaScriptEngine.ActiveScript
 {
 	[Serializable]
 	internal sealed class ActiveScriptException : Exception
 	{
+		/// <summary>
+		/// Error code
+		/// </summary>
+		private int _errorCode;
+
+		/// <summary>
+		/// WCode
+		/// </summary>
+		private short _errorWCode;
+
+		/// <summary>
+		/// Application specific source context
+		/// </summary>
+		private uint _sourceContext;
+
+		/// <summary>
+		/// Subcategory of error
+		/// </summary>
+		private string _subcategory = string.Empty;
+
+		/// <summary>
+		/// Line number on which the error occurred
+		/// </summary>
+		private uint _lineNumber;
+
+		/// <summary>
+		/// Column number on which the error occurred
+		/// </summary>
+		private int _columnNumber;
+
+		/// <summary>
+		/// Content of the line on which the error occurred
+		/// </summary>
+		private string _sourceError = string.Empty;
+
 		/// <summary>
 		/// Gets or sets a error code
 		/// </summary>
 		public int ErrorCode
 		{
-			get;
-			set;
+			get { return _errorCode; }
+			set { _errorCode = value; }
 		}
 
 		/// <summary>
 		/// Gets or sets a WCode
 		/// </summary>
 		public short ErrorWCode
 		{
-			get;
-			set;
+			get { return _errorWCode; }
+			set { _errorWCode = value; }
 		}
 
 		/// <summary>
 		/// Gets or sets a application specific source context
 		/// </summary>
 		public uint SourceContext
 		{
-			get;
-			set;
+			get { return _sourceContext; }
+			set { _sourceContext = value; }
 		}
 
 		/// <summary>
 		/// Gets or sets a subcategory of error
 		/// </summary>
 		public string Subcategory
 		{
-			get;
-			set;
+			get { return _subcategory; }
+			set { _subcategory = value; }
 		}
 
 		/// <summary>
 		/// Gets or sets a line number on which the error occurred
 		/// </summary>
 		public uint LineNumber
 		{
-			get;
-			set;
+			get { return _lineNumber; }
+			set { _lineNumber = value; }
 		}
 
 		/// <summary>
 		/// Gets or sets a column number on which the error occurred
 		/// </summary>
 		public int ColumnNumber
 		{
-			get;
-			set;
+			get { return _columnNumber; }
+			set { _columnNumber = value; }
 		}
 
 		/// <summary>
 		/// Gets or sets a content of the line on which the error occurred
 		/// </summary>
 		public string SourceError
 		{
-			get;
-			set;
+			get { return _sourceError; }
+			set { _sourceError = value; }
 		}
 
 
 		/// <summary>
 		/// Initializes a new instance of the <see cref="ActiveScriptException"/> class
-		/// </summary>
-		public ActiveScriptException()
-		{ }
-
-		/// <summary>
-		/// Initializes a new instance of the <see cref="ActiveScriptException"/> class
+		/// with a specified error message
 		/// </summary>
 		/// <param name="message">The message</param>
 		public ActiveScriptException(string message)
@@ -88,14 +119,8 @@ public ActiveScriptException(string message)
 
 		/// <summary>
 		/// Initializes a new instance of the <see cref="ActiveScriptException"/> class
-		/// </summary>
-		/// <param name="innerException">The inner exception</param>
-		public ActiveScriptException(Exception innerException)
-			: base(null, innerException)
-		{ }
-
-		/// <summary>
-		/// Initializes a new instance of the <see cref="ActiveScriptException"/> class
+		/// with a specified error message and a reference to the inner exception
+		/// that is the cause of this exception
 		/// </summary>
 		/// <param name="message">The message</param>
 		/// <param name="innerException">The inner exception</param>
@@ -104,21 +129,24 @@ public ActiveScriptException(string message, Exception innerException)
 		{ }
 
 		/// <summary>
-		/// Initializes a new instance of the <see cref="ActiveScriptException"/> class
+		/// Initializes a new instance of the <see cref="ActiveScriptException"/> class with serialized data
 		/// </summary>
-		/// <param name="info">The <see cref="T:System.Runtime.Serialization.SerializationInfo"/>
-		/// that holds the serialized object data about the exception being thrown</param>
-		/// <param name="context">The <see cref="T:System.Runtime.Serialization.StreamingContext"/>
-		/// that contains contextual information about the source or destination</param>
-		/// <exception cref="T:System.ArgumentNullException">
-		/// The <paramref name="info"/> parameter is null
-		/// </exception>
-		/// <exception cref="T:System.Runtime.Serialization.SerializationException">
-		/// The class name is null or <see cref="P:System.Exception.HResult"/> is zero (0)
-		/// </exception>
+		/// <param name="info">The object that holds the serialized data</param>
+		/// <param name="context">The contextual information about the source or destination</param>
 		private ActiveScriptException(SerializationInfo info, StreamingContext context)
 			: base(info, context)
-		{ }
+		{
+			if (info != null)
+			{
+				_errorCode = info.GetInt32("ErrorCode");
+				_errorWCode = info.GetInt16("ErrorWCode");
+				_sourceContext = info.GetUInt32("SourceContext");
+				_subcategory = info.GetString("Subcategory");
+				_lineNumber = info.GetUInt32("LineNumber");
+				_columnNumber = info.GetInt32("ColumnNumber");
+				_sourceError = info.GetString("SourceError");
+			}
+		}
 
 
 		internal static ActiveScriptException Create(IActiveScriptError error)
@@ -191,6 +219,33 @@ internal static ActiveScriptException Create(IActiveScriptError error)
 
 			return activeScriptException;
 		}
+
+		#region Exception overrides
+
+		/// <summary>
+		/// Populates a <see cref="SerializationInfo"/> with the data needed to serialize the target object
+		/// </summary>
+		/// <param name="info">The <see cref="SerializationInfo"/> to populate with data</param>
+		/// <param name="context">The destination (see <see cref="StreamingContext"/>) for this serialization</param>
+		[SecurityPermission(SecurityAction.Demand, SerializationFormatter = true)]
+		public override void GetObjectData(SerializationInfo info, StreamingContext context)
+		{
+			if (info == null)
+			{
+				throw new ArgumentNullException("info");
+			}
+
+			base.GetObjectData(info, context);
+			info.AddValue("ErrorCode", _errorCode);
+			info.AddValue("ErrorWCode", _errorWCode);
+			info.AddValue("SourceContext", _sourceContext);
+			info.AddValue("Subcategory", _subcategory);
+			info.AddValue("LineNumber", _lineNumber);
+			info.AddValue("ColumnNumber", _columnNumber);
+			info.AddValue("SourceError", _sourceError);
+		}
+
+		#endregion
 	}
 }
 #endif

src/MsieJavaScriptEngine/ActiveScript/ActiveScriptJsEngineBase.cs

@@ -267,7 +267,6 @@ private JsRuntimeException ConvertActiveScriptExceptionToJsRuntimeException(
 				LineNumber = (int)activeScriptException.LineNumber,
 				ColumnNumber = activeScriptException.ColumnNumber,
 				SourceFragment = activeScriptException.SourceError,
-				Source = activeScriptException.Source,
 				HelpLink = activeScriptException.HelpLink
 			};
 

src/MsieJavaScriptEngine/JsEngineLoadException.cs

@@ -1,10 +1,16 @@
 using System;
+#if !NETSTANDARD1_3
+using System.Runtime.Serialization;
+#endif
 
 namespace MsieJavaScriptEngine
 {
 	/// <summary>
-	/// The exception that is thrown when a loading of JavaScript engine is failed
+	/// The exception that is thrown when a loading of JS engine is failed
 	/// </summary>
+#if !NETSTANDARD1_3
+	[Serializable]
+#endif
 	public sealed class JsEngineLoadException : JsException
 	{
 		/// <summary>
@@ -13,38 +19,48 @@ public sealed class JsEngineLoadException : JsException
 		/// </summary>
 		/// <param name="message">The message that describes the error</param>
 		public JsEngineLoadException(string message)
-			: this(message, string.Empty)
+			: base(message)
 		{ }
 
 		/// <summary>
 		/// Initializes a new instance of the <see cref="JsEngineLoadException"/> class
-		/// with a specified error message and a reference to the inner exception that is the cause of this exception
+		/// with a specified error message and a reference to the inner exception
+		/// that is the cause of this exception
 		/// </summary>
 		/// <param name="message">The error message that explains the reason for the exception</param>
 		/// <param name="innerException">The exception that is the cause of the current exception</param>
 		public JsEngineLoadException(string message, Exception innerException)
-			: this(message, string.Empty, innerException)
+			: base(message, innerException)
 		{ }
 
 		/// <summary>
 		/// Initializes a new instance of the <see cref="JsEngineLoadException"/> class
-		/// with a specified error message and a reference to the inner exception that is the cause of this exception
 		/// </summary>
 		/// <param name="message">The error message that explains the reason for the exception</param>
-		/// <param name="engineMode">Name of JavaScript engine mode</param>
+		/// <param name="engineMode">Name of JS engine mode</param>
 		public JsEngineLoadException(string message, string engineMode)
-			: this(message, engineMode, null)
+			: base(message, engineMode)
 		{ }
 
 		/// <summary>
 		/// Initializes a new instance of the <see cref="JsEngineLoadException"/> class
-		/// with a specified error message and a reference to the inner exception that is the cause of this exception
 		/// </summary>
 		/// <param name="message">The error message that explains the reason for the exception</param>
-		/// <param name="engineMode">Name of JavaScript engine mode</param>
+		/// <param name="engineMode">Name of JS engine mode</param>
 		/// <param name="innerException">The exception that is the cause of the current exception</param>
 		public JsEngineLoadException(string message, string engineMode, Exception innerException)
 			: base(message, engineMode, innerException)
 		{ }
+#if !NETSTANDARD1_3
+
+		/// <summary>
+		/// Initializes a new instance of the <see cref="JsEngineLoadException"/> class with serialized data
+		/// </summary>
+		/// <param name="info">The object that holds the serialized data</param>
+		/// <param name="context">The contextual information about the source or destination</param>
+		private JsEngineLoadException(SerializationInfo info, StreamingContext context)
+			: base(info, context)
+		{ }
+#endif
 	}
 }