Fix various compile warnings #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubruhin
force-pushed
the
fix-compile-warnings
branch
2 times, most recently
from
9022aa0 to
e075591
Compare
ubruhin
force-pushed
the
fix-compile-warnings
branch
from
e075591 to
f3705fe
Compare
|
@TartanLlama any chance of having this PR merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some compile warnings. To avoid introducing new warnings by accident, I added the option
OPTIONAL_WERRORto the CMake config which allows to compile with the flags-Werror,-Wall,-Wextraand-pedantic. This option is disabled by default (to avoid errors when using for example a more recent compiler), but enabled on CI to make CI fail on warnings.In addition, I added new CI jobs for GCC 9.x to increase compiler coverage.
Please let me know if I should change something. Especially with CMake I have no experience at all.