Skip to content

Conversation

@phenomenalCode
Copy link

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job Darius! Make sure you get a score of at least 95% in Lighthouse and that all contrasts are OK.

And fix this little styling bug (the button):

Screenshot 2025-06-09 at 13 22 01

@HIPPIEKICK
Copy link
Contributor

ping

@phenomenalCode
Copy link
Author

phenomenalCode commented Aug 5, 2025 via email

@HIPPIEKICK
Copy link
Contributor

I fixed the button.i will add more accessibility tags. And bring minimize javascript to bring up mobile performance.

On Tue, Aug 5, 2025 at 2:56 PM Matilda Brunemalm @.> wrote: HIPPIEKICK left a comment (Technigo/js-project-todo#28) <#28 (comment)> ping — Reply to this email directly, view it on GitHub <#28 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BKQ46H2OJDFZFFKIFXI3T433MCSZBAVCNFSM6AAAAAB6SH2K32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNJVGEYDMOBQGY . You are receiving this because you authored the thread.Message ID: @.>

You haven't pushed any changes. Let me know when your repo is updated and I'll review

@phenomenalCode
Copy link
Author

new updates
same link: https://darius-to-do-app.netlify.app/

i have fixed the bug and lighthouse scores are 96
Performance
100
Accessibility
100
Best Practices
100
SEO
96
FCP
+8
LCP
+24
TBT
+29
CLS
+25
SI
+10
Performance
Values are estimated and may vary. The performance score is calculated directly from these metrics.See calculator.
0–49
50–89
90–100

@HIPPIEKICK
Copy link
Contributor

You still need to fix the button, accessibility and responsiveness, see images:

Screenshot 2025-08-21 at 14 21 49 Screenshot 2025-08-21 at 14 22 31

@phenomenalCode
Copy link
Author

phenomenalCode commented Aug 21, 2025 via email

@phenomenalCode
Copy link
Author

phenomenalCode commented Aug 22, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants