refactoring: better code modularization

Author: fmancardi

lib/project/projectView.php

@@ -7,12 +7,10 @@
  *
  * @package 	  TestLink
  * @author 		  TestLink community
- * @copyright   2007-2016, TestLink community 
+ * @copyright   2007-2019, TestLink community 
  * @filesource  projectView.php
  * @link 		    http://www.testlink.org/
  *
- * @internal revisions
- * @since 1.9.9
  */
 
 
@@ -21,52 +19,15 @@
 testlinkInitPage($db,false,false,"checkRights");
 
 $templateCfg = templateConfiguration();
-
-$smarty = new TLSmarty();
-$imgSet = $smarty->getImages();
 $args = init_args();
-$gui = initializeGui($db,$args);
+list($gui,$smarty) = initializeGui($db,$args);
 
 $template2launch = $templateCfg->default_template;
-if(!is_null($gui->tprojects) || $args->doAction=='list')
-{  
-  $labels = init_labels(array('active_integration' => null, 'inactive_integration' => null));
-  for($idx=0; $idx < $gui->itemQty; $idx++)
-  {
-    $gui->tprojects[$idx]['itstatusImg'] = '';
-    if($gui->tprojects[$idx]['itname'] != '')
-    {
-      $ak = ($gui->tprojects[$idx]['issue_tracker_enabled']) ? 'active' : 'inactive';
-      $gui->tprojects[$idx]['itstatusImg'] = ' <img title="' . $labels[$ak . '_integration'] . '" ' .
-                                             ' alt="' . $labels[$ak . '_integration'] . '" ' .
-                                             ' src="' . $imgSet[$ak] . '"/>';
-    } 
-    
-    $gui->tprojects[$idx]['ctstatusImg'] = '';
-    if($gui->tprojects[$idx]['ctname'] != '')
-    {
-      $ak = ($gui->tprojects[$idx]['code_tracker_enabled']) ? 'active' : 'inactive';
-      $gui->tprojects[$idx]['ctstatusImg'] = ' <img title="' . $labels[$ak . '_integration'] . '" ' .
-                                             ' alt="' . $labels[$ak . '_integration'] . '" ' .
-                                             ' src="' . $imgSet[$ak] . '"/>';
-    } 
-    
-
-    $gui->tprojects[$idx]['rmsstatusImg'] = '';
-    if($gui->tprojects[$idx]['rmsname'] != '')
-    {
-      $ak = ($gui->tprojects[$idx]['reqmgr_integration_enabled']) ? 'active' : 'inactive';
-      $gui->tprojects[$idx]['rmsstatusImg'] = ' <img title="' . $labels[$ak . '_integration'] . '" ' .
-                                              ' alt="' . $labels[$ak . '_integration'] . '" ' .
-                                              ' src="' . $imgSet[$ak] . '"/>';
-    } 
-  }
-
-  if(count($gui->tprojects) == 0)
-  {
+if(!is_null($gui->tprojects) || $args->doAction=='list') {  
+  if( $gui->itemQty == 0 ) {
     $template2launch = "projectEdit.tpl"; 
     $gui->doAction = "create";
-  }
+  } 
 }
 
 $smarty->assign('gui',$gui);
@@ -77,8 +38,7 @@
  * 
  *
  */
-function init_args()
-{
+function init_args() {
   $_REQUEST = strings_stripSlashes($_REQUEST);
 
   $args = new stdClass();
@@ -109,16 +69,17 @@ function init_args()
  * 
  *
  */
-function initializeGui(&$dbHandler,&$argsObj)
-{
+function initializeGui(&$dbHandler,&$argsObj) {
+
+  $tplEngine = new TLSmarty();
+
   $guiObj = new stdClass();
   $guiObj->doAction = $argsObj->doAction;
   $guiObj->canManage = $argsObj->user->hasRight($dbHandler,"mgt_modify_product");
   $guiObj->name = is_null($argsObj->name) ? '' : $argsObj->name;
   $guiObj->feedback = '';
 
-  switch($argsObj->doAction)
-  {
+  switch($argsObj->doAction) {
     case 'list':
       $filters = null;
     break;
@@ -131,7 +92,8 @@ function initializeGui(&$dbHandler,&$argsObj)
   }
 
   $tproject_mgr = new testproject($dbHandler);
-  $opt = array('output' => 'array_of_map', 'order_by' => " ORDER BY name ", 'add_issuetracker' => true,
+  $opt = array('output' => 'array_of_map', 'order_by' => " ORDER BY name ", 
+               'add_issuetracker' => true,
                'add_codetracker' => true, 'add_reqmgrsystem' => true);
   $guiObj->tprojects = $tproject_mgr->get_accessible_for_user($argsObj->userID,$opt,$filters);
   $guiObj->pageTitle = lang_get('title_testproject_management');
@@ -141,16 +103,44 @@ function initializeGui(&$dbHandler,&$argsObj)
 
   $guiObj->itemQty = count($guiObj->tprojects);
 
-  if($guiObj->itemQty > 0)
-  {
+  if($guiObj->itemQty > 0) {
     $guiObj->pageTitle .= ' ' . sprintf(lang_get('available_test_projects'),$guiObj->itemQty);
+ 
+    initIntegrations($guiObj->tprojects,$guiObj->itemQty,$tplEngine);
   }  
 
-  return $guiObj;
+  return array($guiObj,$tplEngine);
 }
 
+/**
+ *
+ */
+function initIntegrations(&$tprojSet,$tprojQty,&$tplEngine) {
+  $labels = init_labels(array('active_integration' => null, 
+                              'inactive_integration' => null));
+
+  $imgSet = $tplEngine->getImages();
+
+  $intk = array('it' => 'issue', 'ct' => 'code');
+  for($idx=0; $idx < $tprojQty; $idx++) {  
+    foreach( $intk as $short => $item ) {
+      $tprojSet[$idx][$short . 'statusImg'] = '';
+      if($tprojSet[$idx][$short . 'name'] != '') {
+        $ak = ($tprojSet[$idx][$item . '_tracker_enabled']) ? 
+              'active' : 'inactive';
+        $tprojSet[$idx][$short . 'statusImg'] = 
+          ' <img title="' . $labels[$ak . '_integration'] . '" ' .
+          ' alt="' . $labels[$ak . '_integration'] . '" ' .
+          ' src="' . $imgSet[$ak] . '"/>';
+      } 
+    }
+  }
+}  
+
 
-function checkRights(&$db,&$user)
-{
+/**
+ *
+ */
+function checkRights(&$db,&$user) {
 	return $user->hasRight($db,'mgt_modify_product');
 }